906536 - [Homescreen] Big icons are overlaped over normal icons

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect, P1)

Description

[Leo]

1. Title : Big icons are overlaped over normal icons
2. Precondition : 
3. Tester's Action : Do the automatic testing using monkey test. 
4. Detailed Symptom (ENG.) : Big icons are overlaped over normal icons
5. Personal email id:  [e-mail]

We don't know how to reproduce it... We are trying to reproduce it.

Comment 1

[Leo]

Attachment: Homescreen_ScreenShot.png

Comment 2

[Leo]

Attachment: Big_icon

I reproduce issue.
Please check video

Comment 3

[Cristian Rodriguez (:crdlc)]

please could you attach traces for this video? adb logcat | grep GeckoConsole

Comment 4

[Leo]

Attachment: Log.TXT

We can't grep "GeckoConsole". So we attach the total log.

Comment 5

[Cristian Rodriguez (:crdlc)]

Hi, could you go to this commit https://github.com/mozilla-b2g/gaia/commit/c97b3e11acad10a757b00fdffb5caab54afb6fea? is it reproducible here?

Thanks

Comment 6

[Jason Smith [:jsmith]]

Can someone check to see if this reproducible on the latest v1-train on leo?

Comment 7

[Sarah Parsons]

Unable to reproduce on today's Leo Comm Build ID: 20130819041202. However, following the instructions in the video that was provided, I was able to get  important apps to fall below Persistent Bar causing apps such as the Dialer, Camera, and SMS apps to become non-functioning until the phone is restarted. 

Attached are a few screenshots for reference. One is just the camera app below the Persistent bar, and the other is both the Dialer and Camera app. 

Environmental Variables
Build ID: 20130819041202
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/285e2afe2a3b
Gaia: 124ed9737f0f44781cb75f763468f1574f753ac0
Platform Version: 18.1
RIL Version: 01.01.00.019.196

Comment 8

[Sarah Parsons]

Attachment: Missing_camera_app_and_Dialer_app.png

Comment 9

[Sarah Parsons]

Attachment: camera_app_Persistent_Bar.png

Comment 10

[Leo]

(In reply to Cristian Rodriguez (:crdlc) from comment #5)
> Hi, could you go to this commit
> https://github.com/mozilla-b2g/gaia/commit/
> c97b3e11acad10a757b00fdffb5caab54afb6fea? is it reproducible here?
> 
> Thanks

In leo version, this patch is already applied...

Comment 11

[Cristian Rodriguez (:crdlc)]

When you reproduce this case of hidden apps behind dock, are you touching with two fingers while dragging? Could you record other video? I cannot reproduce it sorry.

Comment 12

[Leo]

Attachment: Big_icon_reproduce2

Reproduce steps :
1. Apps behind dock
2. Try to edit only one apps
3. Release current edit app and try to edit other app at the same time

But, this is reproduced not 100% but sometimes. So, I think you will try many times.

Comment 13

[Leo]

Is there any unpdate?

Comment 14

[Cristian Rodriguez (:crdlc)]

Attachment: 906536.patch

After several minutes I could reproduce it once and I saw a fail 

E/GeckoConsole(  510): [JavaScript Error: "ReferenceError: onPageReady is not defined" {file: "app://homescreen.gaiamobile.org/js/page.js" line: 739}]

After applying this patch, I cannot reproduce again

Could you take a look?

Thanks

Comment 15

[Leo]

Attachment: Other issue is occured

When I apply 906536.patch, I can see other issue.
Cannot move icon from dock bar to middle of screen.
Check video please

Comment 16

[Cristian Rodriguez (:crdlc)]

The patch fixes a mistake what I could see on traces about wrong function definition. Evidently, it doesn't introduce any regression or problem. I suppose that there is some other issue on the code but I cannot reproduce the failure recorded in the video. I don't know if it depends on gecko release what we are using (in any case this is a corner case IMHO). 3/4 weeks ago it didn't happen and the code hasn't been changed.

> Cannot move icon from dock bar to middle of screen

This is not the root issue, if you see your steps, something was wrong while you were dragging the firefox browser app. Since then the drag&drop was corrupted and you cannot move icons from the dock to screen or whatever. What was happen? Maybe some traces could be interesting here in order to looking for any error, could you provide me with?

Thanks a lot

Comment 18

[Francisco Jordano [:arcturus] [:francisco]]

Comment on attachment 793879 [details] [diff] [review]
906536.patch

Review of attachment 793879 [details] [diff] [review]:
-----------------------------------------------------------------

Had to modify the patch supplied, adding an extra line to the end of the file in order to apply.

Apart from that, all unit tests are passing locally, and in the phone couldn't reproduce the error mentioned in this bug.

Thanks Cristian!

Comment 19

[Cristian Rodriguez (:crdlc)]

Merged into master

https://github.com/mozilla-b2g/gaia/commit/eedcb5c5dd119d61d09be5a952793b39c29d36bc

Comment 20

[Cristian Rodriguez (:crdlc)]

Uplifted to v1-train: https://github.com/mozilla-b2g/gaia/commit/5a71effab99deb75adae464c22436d7f89aaa864

I did that uplift myself to save time. The uplift to the hd branch should be clean, however, so I'll leave that to the sheriff because I am not sure if it will uplift or not

Comment 21

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1.0hd: 5a71effab99deb75adae464c22436d7f89aaa864

Comment 22

[sbogati]

Issue no longer reproduces on the Leo device.
Build ID: 20130828041203
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/c3b4683d1360
Gaia: 518178ca234c98eb1ca0c0997b9d59faea640a85
Platform Version: 18.1
RIL Version: 01.01.00.019.205
Big icons are no longer overlapped over normal icons.

Comment 23

[Leo]

Even if I apply this patch, this issue is reproduced rarely. But, this bugzilla is already closed, so I re-upload Bug 911643.

Please check this