906642 - [Leo][Gaia] Changed progress bar image in Leo device for Browser, Gallery and Video apps

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia, enhancement)

Description

[Leo]

Title: Progress bar image in Leo device for Browser, Gallery and Video apps.

Description: In the apps mentioned below Progress bar GUI has been updated with an animated GIF file (progress.gif) with small CSS modification. Please find the attached GIF files.

Gallery app:
#throbber {
  height: 24px;
-  background-image: url(images/progress.png);
+  background-image: url(images/progress.gif);
}
Placed an progress.gif file in apps/gallery/style/images folder

Video app:
#throbber > div {
  height: 2.4rem;
-  background-image: url(images/progress.png);
+  background-image: url(images/progress.gif);
  background-size: auto 100%;
}
Placed an progress.gif file in apps/video/style/images folder

Browser app:
No change in the code.
But placed an progress.gif file in apps/browser/style/images folder

Comment 1

[Leo]

Attachment: Progress bar animated GIF files

Comment 2

[vsireesha246]

Attachment: Pointer to Pull Request.html

Hi Wayne,

Would you please assign the reviewer for this bug.

Thanks..
Sireesha

Comment 3

[Wayne Chang [:wchang]]

Hi Stephany,
Can you point the right UX to review the visual change here?

Sireesha,
Can you restore the request for review flag for code review?

Comment 4

[Stephany Wilkes]

Flagging Peter, as this affects Media visuals, and Harly, as I believe this may affect Building Blocks (as in, be a departure from them, though I may be wrong). Harly, if this is not appropriate or necessary, please feel free to just remove your ni?. Thanks!

Comment 5

[Wayne Chang [:wchang]]

Comment on attachment 8371392 [details]
Pointer to Pull Request.html

Hi Dominic, 
As discussed please help to review and provide some feedback here, thanks!

Comment 6

[Dominic Kuo [:dkuo]]

Comment on attachment 8371392 [details]
Pointer to Pull Request.html

Sireesha, I think there are existing issues about the progress bar among gallery, video and browser apps. Before we fix this bug, we should let all the apps to use the same progress bar styles, after that, all the apps can use the same progress.gif from the shared folder, and if we want to change the style of the progress bar in the future, we can just change the progress.gif, instead of modifying all the apps that use the progress bar.

And let' also wait for Peter and Harly's feedback before a second review because this is about the visual changes, after they provide the information/images, we can address the issues with the latest resources, thanks.

Comment 7

[Harly Hsu[:harly]]

I totally agree with Dominic that the progress bar should be treated as an OS-wide/Building Block topic. If Peter is OK with the visual, then we can start to implement this into Building Blocks.

Comment 8

[Peter La]

Hi,

Who designed this?  I've never seen this before.

This is something that has to be reviewed by our team while it's being designed, not after it's implemented.  If this is something that has gone through Visual Design and I was just not aware of it, that's fine, but if it didn't go through visual design until now... that's an issue.

I'm not ok with this design, it needs to be looked at by someone on our team.

Comment 9

[Patryk Adamczyk [:patryk] UX]

I recall Chris Lee saying something that LG designed their own for their own builds. But clearly this has gotten into master, we should use are established progress bar instead system wide.

Comment 10

[BMO Automation]

Firefox OS is not being worked on