Closed
Bug 906650
Opened 11 years ago
Closed 11 years ago
caldav calendar sync failing with aUri is null
Categories
(Calendar :: Provider: CalDAV, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: TheOne, Assigned: mmecca)
Details
Attachments
(1 file)
1.14 KB,
patch
|
Fallen
:
review+
TheOne
:
feedback+
Fallen
:
approval-calendar-aurora+
Fallen
:
approval-calendar-beta+
|
Details | Diff | Splinter Review |
When trying to sync my caldav calendar, I get following errors: Error: aUri is null Source file: [...]/components/calDavCalendar.js Line: 328 ---------- Error: [calCachedCalendar] replay action failed: null, uri=<url>, result=2147500037, op=[xpconnect wrapped calIOperation] (Note: I removed the calendar url). It seems that this is because bug 853236 where prepHttpChannel is added (http://hg.mozilla.org/comm-central/diff/723ed450d2e7/calendar/providers/caldav/calDavCalendar.js#l1.49) http://hg.mozilla.org/comm-central/diff/723ed450d2e7/calendar/providers/caldav/calDavCalendar.js#l1.526 calls prepHttpChannel with aUri = null and this is not checked for in prepHttpChannel.
Comment 1•11 years ago
|
||
Matt, do you think you could look into this soon? Andreas tells me this used to work on 2.5b1, but now fails. There were three commits inbetween: http://hg.mozilla.org/releases/comm-beta/rev/723ed450d2e7 http://hg.mozilla.org/releases/comm-beta/rev/cd19366c9f93 http://hg.mozilla.org/releases/comm-beta/rev/131ed16e2581
Reporter | ||
Comment 2•11 years ago
|
||
Calling: if (!aUri) { cal.ERROR("uri missing" + cal.STACK(10)); } right before the error happens outputs the following: Error: uri missing 1: [file:///C:/Users/me/AppData/Roaming/Thunderbird/Profiles/9qtdiaml.default/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/components/calDavCalendar.js:325] calDavCalendar.prototype.prepHttpChannel 2: [file:///C:/Users/me/AppData/Roaming/Thunderbird/Profiles/9qtdiaml.default/extensions/%7Be2fda1a4-762b-4020-b5ad-a41df1933103%7D/components/calDavCalendar.js:2780] caldav_asyncOonChannelRedirect 3: [null:0] null Warning: There has been an error reading data for calendar: ownCloud. However, this error is believed to be minor, so the program will attempt to continue. Error code: DAV_NOT_DAV. Description: The resource at <url> is either not a DAV collection or not available Warning: There has been an error reading data for calendar: ownCloud. However, this error is believed to be minor, so the program will attempt to continue. Error code: READ_FAILED. Description: Error: [calCachedCalendar] replay action failed: null, uri=<url>, result=2147500037, op=[xpconnect wrapped calIOperation]
Assignee | ||
Comment 3•11 years ago
|
||
cal.prepHttpChannel accepts a null aUri argument if using an existing channel, as in the case of a redirect. I wasn't able to reproduce the error - Andreas, could you test this patch?
Assignee: nobody → matthew.mecca
Status: NEW → ASSIGNED
Attachment #794439 -
Flags: review?(philipp)
Attachment #794439 -
Flags: feedback?(mail)
Reporter | ||
Comment 4•11 years ago
|
||
(In reply to Matthew Mecca [:mmecca] from comment #3) > Created attachment 794439 [details] [diff] [review] > Fix v1 > > cal.prepHttpChannel accepts a null aUri argument if using an existing > channel, as in the case of a redirect. > > I wasn't able to reproduce the error - Andreas, could you test this patch? That patch resolves the issue.
Reporter | ||
Updated•11 years ago
|
Attachment #794439 -
Flags: feedback?(mail) → feedback+
Comment 5•11 years ago
|
||
Comment on attachment 794439 [details] [diff] [review] Fix v1 Ok, lets do it. Please push to all branches.
Attachment #794439 -
Flags: review?(philipp)
Attachment #794439 -
Flags: review+
Attachment #794439 -
Flags: approval-calendar-beta+
Attachment #794439 -
Flags: approval-calendar-aurora+
Assignee | ||
Updated•11 years ago
|
Keywords: checkin-needed
Comment 6•11 years ago
|
||
https://hg.mozilla.org/comm-central/rev/38799a166128 https://hg.mozilla.org/releases/comm-aurora/rev/3587f0601a13 https://hg.mozilla.org/releases/comm-beta/rev/9a9d7fde5c38
You need to log in
before you can comment on or make changes to this bug.
Description
•