906673 - Keyboard shortcut to enter Private Browsing Mode conflict: privateBrowsingCmd.commandkey

Status: RESOLVED FIXED

(Mozilla Localizations :: ga-IE / Irish, defect)

Description

[Andrei Eftimie]

The keyboard shortcut to enter Private Browsing Mode is in conflict with the reload command.

http://mxr.mozilla.org/l10n-central/source/ga-IE/browser/chrome/browser/browser.dtd#253

To trigger Private Browsing Mode with this locale you would use Cmd[Ctrl]+Shift+R which will trigger the Reload command.

Comment 1

[Kevin Scannell]

Thanks for catching this.   Fixed on Aurora branch:

http://hg.mozilla.org/releases/l10n/mozilla-aurora/ga-IE/rev/a9b2c6377541

Will test and sign off for next release.

Comment 2

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Just to add we caught this issue with our Mozmill functional tests. Adding whiteboard entry.

Comment 3

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Oh, can we also get this fixed for beta? For the mozilla-release and esr 17 branch it's too late.

Comment 4

[Kevin Scannell]

Done on beta:
http://hg.mozilla.org/releases/l10n/mozilla-beta/ga-IE/rev/1b868024ec46

Comment 5

[Andrei Eftimie]

Thanks Kevin!

Comment 6

[Andrei Eftimie]

Kevin, while this change works fine on OSX,
under Windows and Linux we are now in another conflict.

Right now, on ga-IE we have:

Responsive Design View
======================
Windows: Ctrl+Shift+M
Linux: Ctrl+Shift+M
OSX: Alt+Cmd+M

Private Browsing Mode
=====================
Windows: Ctrl+Shift+M
Linux: Ctrl+Shift+M
OSX: Cmd+Shift+M

Comment 7

[Andrei Eftimie]

Kevin, any news on getting this conflict properly solved?

Comment 8

[Kevin Scannell]

Sorry about the delay on this.  Finally found the time to do a careful survey of the top-level command/access keys.  I think this change should work and avoid conflicts on all platforms:

http://hg.mozilla.org/releases/l10n/mozilla-aurora/ga-IE/rev/784a2389d6ff

Comment 9

[Andrei Eftimie]

Thanks Kevin,

I can confirmed this is fixed on Aurora.
Can you push this to Beta as well?

Comment 10

[Kevin Scannell]

Pushed to beta:
http://hg.mozilla.org/releases/l10n/mozilla-beta/ga-IE/rev/95f49e2b852d

I'll test and sign off before end of cycle.

Comment 11

[Andrei Eftimie]

Hi Kevin,
I was expecting to see this change in today's Beta, but unfortunately it is not there yet.

It would be great to have it sign off and land, I think we'll also have a beta 10 build next week.

Thanks

Comment 12

[Andrei Eftimie]

Unfortunately the fix didn't make it into 25 :(
The issue is fixed from 26 upwards.

Comment 13

[Henrik Skupin [:whimboo][⌚️UTC+2]]

The last sign-off for this locale was on Aug. 21, 2013:
https://l10n.mozilla.org/shipping/signoffs/ga-IE/fx25#4bfb30bd058e

As long as this fix hasn't been signed off from, I would rather not close the bug.

Comment 14

[Kevin Scannell]

I just signed off.

Comment 15

[Henrik Skupin [:whimboo][⌚️UTC+2]]

This has not been finalized yet. The signoff is still under review pending.

Comment 16

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Kevin, I still don't see this fix as being landed on aurora, which is the branch we use for testing all the locales the first time:
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ga-IE/

Also I still don't see an accepted (reviewed) sign-off for beta yet.

We have to wait with closing this bug until both conditions have been fixed.

Comment 17

[Francesco Lodolo [:flod]]

Henrik, you're commenting on a bug where the last activity was over a year ago (November 2013) for Firefox 26.

As far as I can tell, the command key is set to M now
http://hg.mozilla.org/releases/l10n/mozilla-aurora/ga-IE/file/default/browser/chrome/browser/browser.dtd#l246

I'll let you close the bug eventually to avoid another dance of open and close.

Comment 18

[Henrik Skupin [:whimboo][⌚️UTC+2]]

Oh! Thanks Flod! This was indeed an accident on my side. This was indeed fixed and as you mentioned a year ago. So sorry for reopening.

Kevin, I can still see conflicts in the shortcuts in the ga-IE locale regarding the changes you did in this bug. The command key 'e' is used in a couple of places. Maybe you want to further think about it, and cover this in a new bug. For details see:

http://mxr.mozilla.org/l10n-mozilla-aurora/search?string=commandkey%2B%22E%22

Something what we usually propose is to use the same keys as in the en-US locale as much as possible. By doing that it will be way easier for people to get used to another locale, in this case your ga-IE one.