906700 - Camino is flagged as "true" by isFirefox() function

Status: VERIFIED FIXED

(www.mozilla.org :: Bedrock, defect, P2)

Description

[Nick Burka [:cremini]]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_8_3) AppleWebKit/537.31 (KHTML, like Gecko) Chrome/26.0.1410.65 Safari/537.31

Steps to reproduce:

This can crop up in a variety of pages, but is most evident on the new firefox/new page (currently not yet live) where the Fx-specific banners are shown for Camino.


Actual results:

Camino is flagged as firefox in isFirefox() (media/js/base/global.js). This happens because the user-agent for Camino includes "(like Firefox/X.X.XX)" and the simple regex in isFirefox matches on it.


Expected results:

The regex in isFirefox() should be updated to not match on "like Firefox".

Comment 1

[Nick Burka [:cremini]]

The UA for Camino is something like: "Mozilla/5.0 (Macintosh; U; Intel Mac OS X 10.8; en; rv:1.9.2.28) Gecko/20120308 Camino/2.1.2 (MultiLang) (like Firefox/3.6.28)"

Comment 2

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/38356069483fba8081e5aed4e419fa64bcd88542
Update isFirefox for Camino UA string. Bug 906700.

https://github.com/mozilla/bedrock/commit/78178f7e17b7ad7629fd8ec10e05757be99550f4
Merge pull request #1185 from jpetto/bug-906700-camino-is-not-firefox

Update isFirefox for Camino UA string. Bug 906700.

Comment 3

[raymond [:retornam] (inactive)]

fixed on stage

Comment 4

[raymond [:retornam] (inactive)]

verified fixed on production