906714 - (url) [meta] Implement URL parser per URL Standard

Status: NEW

(Core :: Networking, task, P5)

Description

[Anne (:annevk)]

We should replace our current URL parser with the one described by http://url.spec.whatwg.org/ per https://groups.google.com/d/msg/mozilla.dev.platform/V0XjJ-uQbcI/37_DpJzgTbAJ

Tests: https://github.com/annevk/url/ (also has "reference" implementation in JavaScript)

Comment 1

[Honza Bambas (:mayhemer)]

I think this time we should use something better then strlen, strstr, strchr etc ;)

Adding dep on bug 1024056.

Comment 2

[Anne (:annevk)]

Just in case someone is working on this, Simon wrote a URL parser in Rust: https://github.com/servo/rust-url/ We plan to change the specification a bit to resemble that structure more as it's a lot nicer: https://www.w3.org/Bugs/Public/show_bug.cgi?id=25946

Comment 3

[David Bruant]

What is the relationship between this bug and bug 1151899 (use a Rust URL parser)?
If the latter happens soon enough, I'm not sure work on this bug (which is about Gecko implementation?) will be that important.

Comment 4

[David Bruant]

(sorry, submitted too quickly).
Said differently, should the focus rather be on making sure the rust url parser is conforming to http://url.spec.whatwg.org/ ?

Comment 5

[Valentin Gosu [:valentin] (he/him)]

(In reply to David Bruant from comment #3)
> What is the relationship between this bug and bug 1151899 (use a Rust URL
> parser)?
> If the latter happens soon enough, I'm not sure work on this bug (which is
> about Gecko implementation?) will be that important.

Bug 1151899 means switching our parsing backend to the one written in Rust.
While the backend is the most important part of conforming to the spec, this bug also covers other issues, such as the DOM APIs and the URL bar in Firefox.

(In reply to David Bruant from comment #4)
> (sorry, submitted too quickly).
> Said differently, should the focus rather be on making sure the rust url
> parser is conforming to http://url.spec.whatwg.org/ ?

The rust parser is doing quite well in conforming to the spec as far as I can tell. Any issues that are found will definitely be fixed.

Comment 6

[Chris Mills [:cmills]]

We already seem to have the web-dev-facing bits of this spec documented, but I'm still adding dev-doc-needed just in case.

Comment 7

[Firefox Bug Husbandry Bot]

Bulk change to priority: https://bugzilla.mozilla.org/show_bug.cgi?id=1399258

Comment 10

[Ben Bucksch (:BenB)]

Hear, hear! Traction after 22 years :-)
Thank you for looking into it.

Comment 11

[Rohith K]

Release Note Request (optional, but appreciated)
[Why is this notable]:
[Affects Firefox for Android]:
[Suggested wording]:
[Links (documentation, blog post, etc)]:

Description:
Please provide an explanation of the feature or change. Include a description of the user scenario in which it would be used and how the user would complete the task(s).
Screenshots and visual UI specs are welcome, but please include sufficient accompanying explanation so that blind members of the accessibility team are able to understand the feature/change.

How do we test this?
If there is an implementation to test, please provide instructions for testing it; e.g. setting preferences, other preparation, how to trigger the UI, etc.

When will this ship?
Tracking bug/issue:
Design documents (e.g. Product Requirements Document, UI spec):
Engineering lead:
Product manager:

The accessibility team has developed the Mozilla Accessibility Release Guidelines which outline what is needed to make user interfaces accessible:
https://wiki.mozilla.org/Accessibility/Guidelines
Please describe the accessibility guidelines you considered and what steps you've taken to address them:

Describe any areas of concern to which you want the accessibility team to give special attention:

Comment 12

[James Graham [:jgraham]]

Interop 2023 Tests

Comment 13

[Simon Pieters [:zcorpan]]

Anticipated fallout of aligning with the URL standard for allowing data: URLs to be base URLs:

• https://bugzilla.mozilla.org/show_bug.cgi?id=1850965
• https://bugzilla.mozilla.org/show_bug.cgi?id=1850967