Compose window doesn't completely dismiss after sending a message in fullscreen

RESOLVED FIXED in Thunderbird 32.0

Status

RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: ekrem.koc, Assigned: jsbruner)

Tracking

Trunk
Thunderbird 32.0
All
Mac OS X

Thunderbird Tracking Flags

(thunderbird_esr3133+ fixed)

Details

Attachments

(3 attachments)

(Reporter)

Description

5 years ago
User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.8; rv:23.0) Gecko/20100101 Firefox/23.0 (Beta/Release)
Build ID: 20130814063812

Steps to reproduce:

Mac OS X 10.8.4.

I often use full screen for Mozilla Thunderbird. I write a new compose and this window is full screen and is the desktop is another place.


Actual results:

When I have sent a compose to someone, than I see that a window is black.


Expected results:

Can the development make: a desktop go close after I sent a compose?

Updated

5 years ago
Group: core-security
(Reporter)

Comment 1

5 years ago
I have made screenshot:
http://picpaste.com/pics/Schermafbeelding_2013-08-19_om_20.49.29-RfADRTQm.1376938430.png

After I sent a compose, I saw a black desktop. Why didn't the desktop close?
Summary: Compose - Window → Suspected screen update problems involving compose window

Comment 2

5 years ago
see this with beta version from http://www.mozilla.org/thunderbird/channel/ ?
Flags: needinfo?(ekrem.koc)
(Reporter)

Comment 3

5 years ago
Created attachment 795603 [details]
tb 24 beta.png
Flags: needinfo?(ekrem.koc)
(Reporter)

Comment 4

5 years ago
Created attachment 795604 [details]
earlybird 25 nightly.png
(Reporter)

Comment 5

5 years ago
@Wayne, 24 and 25 TB doesnt work too )-: see attachment
(Reporter)

Comment 6

5 years ago
If I close an address book window (full screen), than is the desktop close too. Why doesn't  the desktop close after the compose window go send or close?
Yep, I'm seeing this too.
Status: UNCONFIRMED → NEW
Component: Untriaged → Message Compose Window
Ever confirmed: true
Summary: Suspected screen update problems involving compose window → Compose window doesn't completely dismiss after sending a message in fullscreen
(In reply to Josiah Bruner [:JosiahOne] from comment #7)
> Yep, I'm seeing this too.

Josiah, could you pls add steps to reproduce? Is "fullscreen" a special feature of MAC OS windows?
(In reply to Thomas D. from comment #8)
> (In reply to Josiah Bruner [:JosiahOne] from comment #7)
> > Yep, I'm seeing this too.
> 
> Josiah, could you pls add steps to reproduce? Is "fullscreen" a special
> feature of MAC OS windows?

Sure thing.

This "fullscreen" is a Cocoa (OS X) API that we use for certain windows (including this one). My guess is that the compose window dismissal forgot about this serparate behavior when it was developed. So although the window is closed, we still need to dismiss the fullscreen state. It's possible that this needs to be done on the widget end of things, since usually OS X applications aren't closed while in fullscreen mode.

STR are simple enough:

Open compose window
Click the fullscreen button in the top right corner of the window
Send message.
Examine behavior.

Fix:

I'll probably do this when I have a chance, but in case anyone wants to take a stab, the idea is simple.

Before we close the window, exit the fullscreen state using Cocoa's enterFullScreen:withOptions: method. We might have a way to accomplish the same method via JS, but I wouldn't know what it is off the top of my head.
(Reporter)

Comment 10

5 years ago
I see that works it; a desktop go close after I sent a compose to someone. Maybe I have adjusted a configuration editor. I had disable all:
- full-screen-api.allow-trusted-requests-only
- full-screen-api.content-only;true
- full-screen-api.enabled
- full-screen-api.pointer-lock.enabled
(Reporter)

Comment 11

5 years ago
Can someone fix this bugs please?
Assignee: nobody → josiah
Status: NEW → ASSIGNED
Created attachment 8428471 [details] [diff] [review]
Fix.

This should fix the issue.
Attachment #8428471 - Flags: review?(mkmelin+mozilla)
Hardware: x86 → All
Version: 17 → Trunk
Flags: needinfo?(mconley)
Mike, so what we were trying yesterday (Well, today, but it will be tomorrow when you read this), didn't work.

Apparently we've lost reference to the window object by DoCommandClose() or something similar, because I can not toggle fullscreen off at that point.

We may still have to use the current solution, but I'm open to other ideas.
By the time we arrive at DoCommandClose() I mean.
Comment on attachment 8428471 [details] [diff] [review]
Fix.

Review of attachment 8428471 [details] [diff] [review]:
-----------------------------------------------------------------

Don't have a mac, but this looks totally reasonable to me. r=mkmelin
Attachment #8428471 - Flags: review?(mkmelin+mozilla) → review+
Thanks.
Flags: needinfo?(mconley)
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/fa19c31d7e11
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 32.0
Comment on attachment 8428471 [details] [diff] [review]
Fix.

[Approval Request Comment]
Regression caused by (bug #): OS X Lion
User impact if declined: Trying to send a message while in full screen will not dismiss the space, forcing the user to dismiss the space themselves.
Testing completed (on c-c, etc.): On comm-beta.
Risk to taking this patch (and alternatives if risky): Very low, minimal JS patch and has been on c-c, c-a, and c-b already.
Attachment #8428471 - Flags: approval-comm-esr31?
Duplicate of this bug: 1044579
Attachment #8428471 - Flags: approval-comm-esr31? → approval-comm-esr31+
tracking-thunderbird_esr31: --- → 33+
Keywords: checkin-needed
status-thunderbird_esr31: --- → fixed
Keywords: checkin-needed
You need to log in before you can comment on or make changes to this bug.