Closed Bug 906757 Opened 6 years ago Closed 6 years ago

Update tab on Mozilla theme to new tab style (Tabzilla)

Categories

(bugzilla.mozilla.org Graveyard :: Sandstone/Mozilla Skin, defect)

Production
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: matej, Assigned: dkl)

Details

Attachments

(2 files)

The new Mozilla theme (which looks great) is using an old, obsolete version of our tab (which is bad). You can find the new version, also called Tabzilla, here:

http://www.mozilla.org/en-US/styleguide/websites/sandstone/tabzilla/

Thanks.
Assignee: nobody → dkl
Attached patch 906757_1.patchSplinter Review
tabzilla.png to be attached separately
Attachment #796256 - Flags: review?(glob)
Attached image tabzilla.png
Place in skins/contrib/Mozilla/tabzilla.png
Comment on attachment 796256 [details] [diff] [review]
906757_1.patch

Review of attachment 796256 [details] [diff] [review]:
-----------------------------------------------------------------

that does look much nicer :)

there's a 1px line above the tabzilla image, which shouldn't be there.
i found that changing the margin on "#header .wrapper" to "-1px auto 0px" fixes that.

r=glob with the issues to be fixed on commit.

::: template/en/default/global/header.html.tmpl
@@ +304,5 @@
>          [% END %]
>        </td>
>        <td id="moz_tab">
> +        <a href="https://www.mozilla.org/" title="Mozilla - Home of the Mozilla Project">
> +          <img src="skins/contrib/Mozilla/tabzilla.png" border="0"></a>

please include width and height attributes to avoid reflow
Attachment #796256 - Flags: review?(glob) → review+
Committing to: bzr+ssh://dlawrence%40mozilla.com@bzr.mozilla.org/bmo/4.2       
modified skins/contrib/Mozilla/global.css
added skins/contrib/Mozilla/tabzilla.png
modified template/en/default/global/header.html.tmpl
Committed revision 8972.
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Thank you! Really appreciate this. When does the change take affect?
(In reply to John Slater from comment #5)
> Thank you! Really appreciate this. When does the change take affect?

Maybe this thursday as part of our normal weekly production push. Just to be clear, we decided not to go with the full pull down menu as mozilla.org and just have the tab graphic as a link to mozilla.org instead. It is still an improvement visually over the old tab for sure.

dkl
That makes total sense. Thanks again.
Product: bugzilla.mozilla.org → bugzilla.mozilla.org Graveyard
You need to log in before you can comment on or make changes to this bug.