906795 - safeErrorString should include a stack

Status: RESOLVED FIXED

(DevTools :: Debugger, defect)

Description

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

It should access the stack property if possible, and if one isn't available, it should just use Error().stack so we will at least know from where the handling was caught.

Comment 1

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

Attachment: bug-906795-safeErrorString.patch

https://tbpl.mozilla.org/?tree=Try&rev=dfb1c4556485

Comment 2

[Victor Porof [:vporof][:vp]]

Comment on attachment 792482 [details] [diff] [review]
bug-906795-safeErrorString.patch

Review of attachment 792482 [details] [diff] [review]:
-----------------------------------------------------------------

r+ with the stuff below addressed.

::: toolkit/devtools/DevToolsUtils.js
@@ +15,5 @@
> +    if (typeof errorString === "string") {
> +      try {
> +        if (aError.stack) {
> +          let stack = aError.stack.toString();
> +          if (typeof stack === "string") {

Might want to add some comments here about all the trys and ifs. Why are you checking the typeof here, for example? If any of the conditionals are false, then nothing is returned, which I don't think is what should happen here.

Comment 3

[Nick Fitzgerald [:fitzgen] [⏰PST; UTC-8]]

https://hg.mozilla.org/integration/fx-team/rev/faca4da6cadd

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/faca4da6cadd

Comment 5

[Jim Blandy :jimb]

Hurrah.