Evme does not display apps under entry_points

RESOLVED FIXED

Status

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: kgrandon, Assigned: kgrandon)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Evme displays apps when typing their name in the searchbar.

Currently apps which make use of entry_points do not appear within the list of apps. We might need to make adjustments to getApps in homescreen.js to handle this.
(Assignee)

Comment 1

5 years ago
Proper solution likely means passing the entry point all the way up to Brain.js: https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/everything.me/js/Brain.js#L931
(Assignee)

Updated

5 years ago
Assignee: nobody → kgrandon
Status: NEW → ASSIGNED
(Assignee)

Comment 2

5 years ago
Created attachment 792484 [details]
Github pull request pointer

Hey Guys,

Here is a possible solution in order to show results from entry points. Adding ran to review E.me changes, and crdlc for the homescreen changes.

Please let me know what you think, thanks!
Attachment #792484 - Flags: review?(ran)
Attachment #792484 - Flags: review?(crdlc)
Comment on attachment 792484 [details]
Github pull request pointer

I am comfortable with your changes on Homescreen part and tests
Attachment #792484 - Flags: review?(crdlc) → review+
Looks good to me Kevin. I commented on a small issue on the PR.
(Assignee)

Comment 5

5 years ago
Thanks Ran! Fixed that issue, please let me know if there's anything else.
Attachment #792484 - Flags: review?(ran) → review+
(Assignee)

Comment 6

5 years ago
Thanks for the reviews! Landed in master: https://github.com/mozilla-b2g/gaia/commit/cb7c9f5500f0908395ac567783ea79fa605a390e
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.