906841 - Evme does not display apps under entry_points

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

Description

[Kevin Grandon :kgrandon]

Evme displays apps when typing their name in the searchbar.

Currently apps which make use of entry_points do not appear within the list of apps. We might need to make adjustments to getApps in homescreen.js to handle this.

Comment 1

[Kevin Grandon :kgrandon]

Proper solution likely means passing the entry point all the way up to Brain.js: https://github.com/mozilla-b2g/gaia/blob/master/apps/homescreen/everything.me/js/Brain.js#L931

Comment 2

[Kevin Grandon :kgrandon]

Attachment: Github pull request pointer

Hey Guys,

Here is a possible solution in order to show results from entry points. Adding ran to review E.me changes, and crdlc for the homescreen changes.

Please let me know what you think, thanks!

Comment 3

[Cristian Rodriguez (:crdlc)]

Comment on attachment 792484 [details]
Github pull request pointer

I am comfortable with your changes on Homescreen part and tests

Comment 4

[Ran Ben Aharon [:ranbena] EverythingMe]

Looks good to me Kevin. I commented on a small issue on the PR.

Comment 5

[Kevin Grandon :kgrandon]

Thanks Ran! Fixed that issue, please let me know if there's anything else.

Comment 6

[Kevin Grandon :kgrandon]

Thanks for the reviews! Landed in master: https://github.com/mozilla-b2g/gaia/commit/cb7c9f5500f0908395ac567783ea79fa605a390e

Comment 7

[Philip Chee]

http://hg.mozilla.org/comm-central/rev/4cd118a58040
http://hg.mozilla.org/comm-central/rev/2e8458f26a91