906866 - SDK strict warning filter not always captures useless warnings

Status: RESOLVED INCOMPLETE

(Add-on SDK Graveyard :: General, defect, P3)

Description

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

It looks like some of the strict warnings are not always captured:
https://github.com/mozilla/addon-sdk/blob/master/lib/sdk/test/harness.js#L425-L439

This causes inconsistent behavior and should be fixed.

Comment 1

[Dave Townsend [:mossop]]

This is kind of pending on the result of bug 906844

Comment 2

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

What warnings aren't being captured, Irakli?

Comment 3

[Irakli Gozalishvili [:irakli] [:gozala] [@gozala]]

(In reply to Wes Kocher (:KWierso) from comment #2)
> What warnings aren't being captured, Irakli?

reference to undefined property exn.stackRunning tests on Firefox 27.0a1/Gecko 27.0a1 ({ec8030f7-c20a-464f-9b0e-13a3a9e97384}) under darwin/x86.
.OpenGL version detected: 210
........JavaScript strict warning: chrome://browser/content/urlbarBindings.xml, line 672: reference to undefined property this._value..

Comment 5

[shweta.universidad]

Hello, 

I am using the mozilla-sdk-master (https://github.com/mozilla/addon-sdk) and if I excute:

> cfx -o run

over a code I've it gives me:

Using binary at '/usr/bin/firefox'.
Using profile at '/tmp/tmpkRrhgR.mozrunner'.
console.error: synctab: 
  Message: SyntaxError: missing ( before formal parameters
  Stack:
    @resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/deprecated/list.js:119
CuddlefishLoader/options<.load@resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/loader/cuddlefish.js:129
@resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/windows/firefox.js:8
CuddlefishLoader/options<.load@resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/loader/cuddlefish.js:129
@resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/windows.js:18
CuddlefishLoader/options<.load@resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/loader/cuddlefish.js:129
@resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/tabs/tabs-firefox.js:7
CuddlefishLoader/options<.load@resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/loader/cuddlefish.js:129
@resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/tabs/tabs.js:18
CuddlefishLoader/options<.load@resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/loader/cuddlefish.js:129
@resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/tabs.js:10
CuddlefishLoader/options<.load@resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/loader/cuddlefish.js:129
@resource://jid1-ljvisjodxppx2g-at-jetpack/synctab/lib/main.js:3
CuddlefishLoader/options<.load@resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/loader/cuddlefish.js:129
run@resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/addon/runner.js:146
startup/<@resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/addon/runner.js:113
resolve@resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/core/promise.js:118
resolve@resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/core/promise.js:118
then@resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/core/promise.js:43
then@resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/core/promise.js:153
resolve@resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/core/promise.js:185
resolve@resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/core/promise.js:118
then@resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/core/promise.js:43
resolve@resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/core/promise.js:185
resolve@resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/core/promise.js:118
resolve@resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/core/promise.js:118
then@resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/core/promise.js:43
then@resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/core/promise.js:153
resolve@resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/core/promise.js:185
resolve@resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/core/promise.js:118
then@resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/core/promise.js:43
resolve@resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/core/promise.js:185
resolve@resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/core/promise.js:118
then@resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/core/promise.js:43
resolve@resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/core/promise.js:185
resolve@resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/core/promise.js:118
then@resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/core/promise.js:43
resolve@resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/core/promise.js:185
resolve@resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/core/promise.js:118
then@resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/core/promise.js:43
resolve@resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/core/promise.js:185
resolve@resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/core/promise.js:118
then@resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/core/promise.js:43
resolve@resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/core/promise.js:185
readAsync/<@resource://extensions.modules.jid1-ljvisjodxppx2g-at-jetpack.commonjs.path/sdk/net/url.js:49
@resource://gre/modules/NetUtil.jsm:137

JavaScript error: chrome://browser/content/urlbarBindings.xml, line 654: aUrl is undefined

And in my lib/main.js on the line 3 where the error gives, I have:

/*Mozilla sdk modules load*/
var data = require("sdk/self").data;
var tabs = require("sdk/tabs");
var pageMod = require("sdk/page-mod");

I don't understand this, this never happened before......

Comment 6

[shweta.universidad]

Mean while, I've changed the javascript.strict : False in the prefs.py to avoid the annoying warnings.

And also, after this update, the error messages of the sdk doesn't specifies where the error was produced (doesn't show the line where is the error, neither the file where is the error), just tells whats the error and that drives me crazy because I've to look over my thousands of lines of codes in all those many files of codes and find out where the error was made. That's annoying!!

Comment 7

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1399562