906899 - Propagate OverrideBuiltins to derived interfaces

Status: NEW

(Core :: DOM: Bindings (WebIDL), defect)

Comment 1

[Boris Zbarsky [:bzbarsky]]

I'm not sure this makes sense.  [OverrideBuiltins] is meaningless unless the interface has a named/indexed getter....

Comment 2

[Andrew McCreight [:mccr8]]

This was something Peter mentioned.  I may be confusing the particulars.

Comment 3

[Peter Van der Beken [:peterv]]

Then we should probably propagate the extended attribute to derived interfaces in the parser.

Comment 4

[Andrew McCreight [:mccr8]]

We can also remove the OverrideBuiltins from ImageData.

Comment 5

[Andrew McCreight [:mccr8]]

I don't remember what this was supposed to be and I'm not working on it.

Comment 6

[Boris Zbarsky [:bzbarsky]]

Peter, do you recall what the idea here was?  Is it just so we can avoid listing overridebuiltins on things like ImageDocument?

Comment 7

[Peter Van der Beken [:peterv]]

(In reply to Boris Zbarsky [:bzbarsky, bz on IRC] from comment #6)

Peter, do you recall what the idea here was? Is it just so we can avoid
listing overridebuiltins on things like ImageDocument?

Well, if you don't set OverrideBuiltins on a derived interface then we don't get the same behaviour as for the base interface, and that would be a bug. And we don't detect if someone forgets to set it on a derived interface.

This is low priority, given we don't expect anything except ImageDocument to use this, but I still think it makes sense to propagate.