906905 - Fix strange MPL 2.0 header formatting

Status: RESOLVED FIXED

(Add-on SDK Graveyard :: General, defect)

Description

[Erik Vold [:erikvold] (please needinfo? me)]

I'm not sure why, but Irakli seems to have used a different formatting than gerv established in https://github.com/mozilla/addon-sdk/commit/1d1864314d54f64a561c2459082767786ca538fa

Anyhow the deviated version makes the files harder to read (because the header is longer with an obtuse ' */') line, which should be removed.

Comment 1

[Erik Vold [:erikvold] (please needinfo? me)]

Also the extra line makes the files slightly larger than they need to be, not just longer.

Comment 2

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1209

Pointer to Github pull-request

Comment 3

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/857491a2b8fb3ed04ef96824f03be275bf9e098c
Bug 906905 - Fix strange MPL 2.0 header formatting

https://github.com/mozilla/addon-sdk/commit/7fbdcb6126a4db2274aa7762b52bcd0879c09106
Merge pull request #1209 from erikvold/906905

Bug 906905 - Fix strange MPL 2.0 header formatting r=@gozala

Comment 4

[Erik Vold [:erikvold] (please needinfo? me)]

Attachment: Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1210

Pointer to Github pull-request

Comment 5

[Jordan Santell [:jsantell] [@jsantell]]

Comment on attachment 792488 [details]
Pointer to Github pull request: https://github.com/mozilla/addon-sdk/pull/1210

Looks good, although there's a test change in test-chrome that not sure if this is to be included in this commit.

Comment 6

[[github robot]]

Commits pushed to master at https://github.com/mozilla/addon-sdk

https://github.com/mozilla/addon-sdk/commit/a3c1c0d8e7659e99959067f217fe1251dfb7643c
Bug 906905 - Fix strange MPL 2.0 header formatting

(cherry picked from commit 857491a2b8fb3ed04ef96824f03be275bf9e098c)

https://github.com/mozilla/addon-sdk/commit/80e2088d7b0fa9e8beabfa48083a2698753b9347
Bug 906905 minor test-chrome.js change was needed due to the MPL header changes

https://github.com/mozilla/addon-sdk/commit/382c692ad1c53fb5a92b7f38f35792329335ff4a
Merge pull request #1210 from erikvold/906905v3

Bug 906905 - Fix strange MPL 2.0 header formatting r=@jsantell