906909 - mozilla::LinkedList::debugAssertIsSane doesn't compile

Status: RESOLVED FIXED

(Core :: MFBT, defect)

Description

[Justin Lebar (not reading bugmail)]

mozilla::LinkedList::debugAssertIsSane() has many compile errors.  Oops.

Patch in a moment.

Comment 1

[Justin Lebar (not reading bugmail)]

Attachment: Patch, v1

Comment 2

[Jeff Walden [:Waldo]]

Comment on attachment 792465 [details] [diff] [review]
Patch, v1

Review of attachment 792465 [details] [diff] [review]:
-----------------------------------------------------------------

Hmm.  If this has to be called to be useful, it's probably not useful.  Could we do any of this checking at list-mutation time, to avoid the need to explicitly call this, somehow?  I dunno, this is obviously fine enough, but it's not a very satisfying solution.

Comment 3

[Justin Lebar (not reading bugmail)]

We could definitely call it sometimes.  I'm just a little wary of making debug builds slow for no reason.

I suppose we could call it whenever we do an O(n) operation.  Which is just Clear().  I guess that's not very good...  :)

Comment 4

[Justin Lebar (not reading bugmail)]

I checked this in since it's an obvious step in the right direction.

I'm definitely not against running debugAssertIsSane at choice points during execution; the question is just: when?  Maybe it's a premature optimization not to do it every time we mutate the list.  Anyway, we can discuss elsewhere (or not; it's still useful for debugging to have this call).

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/35c8fa3d4fe7