907041 - [B2G][Helix][Wangchao]The shutdown animation is abnormal when the device rotates 90 degrees.

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::System, defect, P1)

Description

[lecky]

Attachment: device.png

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E; Tablet PC 2.0)

Steps to reproduce:

1.open browser and the device rotates 90 degrees.
2.then power off.


Actual results:

1. The power off animation is abnormal.(see in attachment)


Expected results:

1. The power off animation should not rotates.

Comment 1

[Wayne Chang [:wchang]]

Marco,

How is the shutdown animation displayed? can we have the orientation locked?

Comment 2

[Marco Chen [:mchen]]

Hi Evelyn,

I found that the shutdown animation is performed by system app (sleep_menu.js) so could you help to check this? Thanks.

Comment 3

[lecky]

Hi Evelyn,
  
  Is there any progress for this issue?

Thanks!

Comment 4

[Evelyn Hung]

Alive, can you help on this? Thanks.

Comment 5

[(inactive after 6/18) Alive Kuo [:alive]]

Let me c.c. Rex about init logo handler + orientation issue.

Comment 6

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Should be a case that we didn't test before. Taking..

Comment 7

[lecky]

I have done some change to fix it:
in sleep_menu.js 
 startPowerOff: function sm_startPowerOff(reboot) {
+    screen.mozLockOrientation('portrait-primary');

Then the problem has been solved.

Thanks!

Comment 8

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Hi Lecky:
Thanks for looking at it. Good point for the solution. But we may still encounter problem when underlying app
is locked in landscape mode. In this case we should confirm landscape mode app is not exposed in portrait.
For the solution now there's still a short period time that landscape-locked app showing in portrait after 
tapping reboot (and right before animation starts).
What we can do may be:
* Postpone locking until poweroff really started. (both customized poweroff and default poweroff)
and/or
* Cancel the fading effect between sleep menu and poweroff animation.

I can help you go through the process of sending a patch if you want.
You can send a patch after eliminating the problem above, and set feedback to me.
I can find you a reviewer for you then.

Comment 9

[lecky]

Hi KM lee:

I'm very glad to receive you patch.

And i will feedback to you as your patch arrive.

Thanks!

Comment 10

[Wayne Chang [:wchang]]

Thanks for the help Rexboy.
Can you confirm if this is a regression at all or has it been like this on v1.0.1 and v1.1 already?

I'll nominate this to koi? for now assuming it is not a regression, if this is a regression then please nominate it to leo? if it also exists on v1-train.


Hi Lecky,

Are you working on the patch as suggested in comment 8?

Comment 11

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Set to leo? based on comment #10 since it's reproducible on v1-train.
if Lecky isn't working on it I can continue the work.

Comment 12

[Jason Smith [:jsmith]]

QA Wanted - Can we confirm this is a regression from 1.01? Test this on 1.01 & 1.1 to be able to confirm.

Comment 13

[Preeti Raghunath(:Preeti)]

But this issue seems too late to land. Even if its regression since 1.0.1, can we not live with it till 1.2?

Comment 14

[lecky]

No, I do not get the patch.

Comment 15

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Attachment: patch

Well the patch is easier than I imagined.

One issue remaining: A landscape-only app appear in portrait
through the semi-transparent background of sleep menu.
But solving this would be more complex than what I do now and it's
just a kind of polish issue so I decide to leave it for now.
(Or we may just set the background opaque to avoid this problem?)

Hello Alive, may you help review this patch?

Comment 16

[Sarah Parsons]

Unable to reproduce on Leo 1.1 Build ID: 20130925041202

Environmental Variables
Build ID: 20130925041202
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/18175c7fdaa6
Gaia: 6d9eec501a209bea945c6f841400ec0a75fac11d
Platform Version: 18.1

Unable to reproduce on Buri 1.1 Build ID: 20130925041202

Environmental Variables
Build ID: 20130925041202
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/18175c7fdaa6
Gaia: 6d9eec501a209bea945c6f841400ec0a75fac11d
Platform Version: 18.1
RIL Version: 01.01.00.019.197 

Unable to reproduce on Buri 1.0.1 Build ID: 20130602070207 

Environmental Variables
Build ID: 20130602070207
Gecko: http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/2cd91c879ced
Gaia: 9ba891c880e588a8f3f8ca30bb932ecae68023a9
Platform Version: 18.0

Comment 17

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

bug 908630?  I think it has to do with the sensor w/ the 09242013 build the sensor doesn't seem to be overreacting.

Could you double check please, lecky?

Comment 18

[Naoki Hirata :nhirata (please use needinfo instead of cc)]

fyi, this is a helix bug only.  changing from leo? to hd?

Comment 19

[(inactive after 6/18) Alive Kuo [:alive]]

Comment on attachment 809707 [details]
patch

r=me

Comment 20

[KM Lee [:rexboy] (inactivate after Sep. 22)]

Landed on master. Thank you Alive!

We need to wait for triage to see if we need to land it on other branches.

master
https://github.com/mozilla-b2g/gaia/commit/aaef2ff42f99fbeba30a1f5b8aa3bed4e011f8e2

Comment 21

[lecky]

HI 
We have verified this issue.Please close it.

Comment 22

[Wayne Chang [:wchang]]

HD+ this per comment 16 indication of HD only.

Sorry Rex, Can you help with HD landing?

Thanks.

Comment 23

[KM Lee [:rexboy] (inactivate after Sep. 22)]

v1.1.0hd
https://github.com/mozilla-b2g/gaia/commit/d2aac8d5893052042c04fb3acbc6f06fa4ea9de2

Comment 24

[Jason Smith [:jsmith]]

Mass-modify - removal of no longer relevant blocking flags.