Closed Bug 907052 Opened 6 years ago Closed 6 years ago

Fix the lack of bug 900159 that breaks MediaDB

Categories

(Firefox OS Graveyard :: Gaia, defect)

ARM
Gonk (Firefox OS)
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: dkuo, Assigned: dkuo)

References

Details

Attachments

(1 file)

The patch of bug 900159 refactored shared/js/device_storage but a small lack breaks the MediaDB, which is in:
https://github.com/mozilla-b2g/gaia/blob/master/shared/js/device_storage/enumerate_all.js#L18

ds_cursor = storages[storageIndex].enumerate(dir, options);

should be:

ds_cursor = storages[storageIndex].enumerate(dir, options || {});

I will just fix this asap so that the media apps will be back to us quickly.
John,

This simple patch just add one line back which was removed in bug 900159, with this patch engineers can still develop the media apps with b2g18 gecko and don't have to switch to m-c build, can you please review this? thanks.
Attachment #792662 - Flags: review?(johu)
Comment on attachment 792662 [details]
Fix the lack of bug 900159

r=me, Thanks for this patch.
Attachment #792662 - Flags: review?(johu) → review+
Thanks, John!

Landed on master: 395c4f2730b7e04ea8b5506e4f31781b0e215ade
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.