Closed
Bug 907125
Opened 11 years ago
Closed 11 years ago
[AccessFu] Impove output for ARIA tabs
Categories
(Core :: Disability Access APIs, defect)
Core
Disability Access APIs
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: MarcoZ, Assigned: MarcoZ)
References
Details
Attachments
(1 file)
7.15 KB,
patch
|
yzen
:
review+
|
Details | Diff | Splinter Review |
1. Shortened role announcements so it no longer says "page tab list" and "page tab", but "tab list" and "tab" instead. This is mere cosmetic and does not require localization changes in other languages unless those languages deem the role names too verbose as well. The localisation ID therefore was not changed on purpose. 2. Expose selected state. 3. Expose item index in total number of items. Resurrected the once present objItem utterance for this we originally had in list items. This is going to benefit both Firefox for Android and Firefox OS.
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #792740 -
Flags: review?(yura.zenevich)
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → marco.zehe
Status: NEW → ASSIGNED
Comment 2•11 years ago
|
||
Comment on attachment 792740 [details] [diff] [review] [AccessFu] Improve the output for ARIA tabs and tab lists Review of attachment 792740 [details] [diff] [review]: ----------------------------------------------------------------- r=me looks great (just one tiny nit). ::: dom/locales/en-US/chrome/accessibility/AccessFu.properties @@ +81,5 @@ > # LOCALIZATION NOTE (listItemsCount): Semi-colon list of plural forms. > # See: http://developer.mozilla.org/en/docs/Localization_and_Plurals > listItemsCount = 1 item;#1 items > > +# LOCALIZATION NOTE: %1$S is the item's role name (e.g. "tab"), %2$S is the position of the item n the set. %3$S is the total number of such items in the set. An expanded example would read "tab 2 of 5". Nit: line too long; lets keep it at around 80 characters
Attachment #792740 -
Flags: review?(yura.zenevich) → review+
Assignee | ||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/8ab3659863d7
Comment 4•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8ab3659863d7
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•