Closed
Bug 907127
Opened 11 years ago
Closed 11 years ago
[zffos1.1][Contacts][Import from Gmail] Not able to import huge number of contacts
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(blocking-b2g:leo+, b2g18 fixed, b2g-v1.1hd fixed)
RESOLVED
FIXED
blocking-b2g | leo+ |
People
(Reporter: juanpbf, Assigned: jmcf, NeedInfo)
References
Details
(Whiteboard: [u=commsapps-user c=contacts p=0])
Attachments
(4 files)
Device: Ikura QC RIL version: "ro.build.firmware_revision=V1.01.00.01.019.180" gaia commit: 4916f82 Merge branch 'zte/ics_strawberry_cdr' of ssh://10.67.16.41:29418/quic/lf/releases/gaia into ics_strawberry_cdr gecko commit: a1c2bb0 ZRL modify ACCEPT Http head for MMS I have not been able to import huge number of contacts from GMail - I tried a GMail account with 838 contacts --> Fail - I tried a GMail account with 451 contacts --> Success! Steps To Reproduce 1. Open Contacts application 2. Select Settings --> import from Gmail 3. Introduce Gmail account details using a Gmail account with a huge number of contacts 4. Select all contacts and import them Expecte Result The progress bar should "progress" and all contacts should be succesfully imported Actual Result The progress bar remains in "0%" forever (check attachment) Nominating to leo? to be discussed in triage
Comment 1•11 years ago
|
||
Product, Please clarify what the upper limit is for the importing contacts.
Flags: needinfo?(ffos-product)
Updated•11 years ago
|
Flags: needinfo?(ffos-product) → needinfo?(wmathanaraj)
Comment 2•11 years ago
|
||
Partner wants to know if there is upper limits. If there is upper limit - what's the reason for this upper limit. - While reaching the upper limit, it should show a message to inform user instead just keep running over there.
Comment 3•11 years ago
|
||
There is a hard limit of 1000 contacts, in the call to the API. But that shouldn't limit the import of the account with 838 contacts. Therefore we will need to investigate what's going on with that account.
Comment 4•11 years ago
|
||
Could you provide the logcat please? Otherwise it's hard to know what's going on.
Updated•11 years ago
|
Flags: needinfo?(wmathanaraj)
Comment 5•11 years ago
|
||
Juan, Could you help to provide logcat for our investigation on this case.
Flags: needinfo?(juan.perezbedmar)
Comment 6•11 years ago
|
||
Juan is on PTO, I add other contact details to get the logs requested :-)
Flags: needinfo?(juan.perezbedmar) → needinfo?(francisco.ramirez1)
Comment 7•11 years ago
|
||
Hi! I've also reproduced this issue, importing process is at 0% progress for ever. However, I've used a google account with 1614 contacts (>1000 that seems to be the hardcoded limit according to previous comments). If we see that there is any kind of limit in the number of contacts imported, if it's not possible to fix it, at least we should warn to the user that it's not possible to import this big number of contacts. Thks, David
Comment 8•11 years ago
|
||
Ivan Can we have access to the actual account in question?
Flags: needinfo?(itsay)
Comment 10•11 years ago
|
||
Ok to fix it for importing up to 1000 contact. Right now we will not warn the user if the limit is reached Comment 7, please fill another bug for that.
Assignee: dscravaglieri → francisco.jordano
blocking-b2g: leo? → leo+
Comment 11•11 years ago
|
||
Hi, taking a look to this since is leo+ Just one question, when entering to https://contacts.google.com in the section My Contacts how many do you have? Thanks!
Comment 12•11 years ago
|
||
Another important question that I forgot to mention. Do you manage to see the contacts list to select which contacts do you want to import?
Comment 13•11 years ago
|
||
Hi, a couple of comments: - Cannot find commit 4916f82 in gaia. (https://github.com/mozilla-b2g/gaia/tree/4916f82) - When I try to import the test account in master it fails, but the problem is not related to the import functionality, it's related to the passive merging that we are adding for version 1.2, hopefully will be solved once we land bug 906756. - I forgot the hard limit is 10000, not 1000. - When I try the test account with 1614 contacts and our daily builds with version 1.1, the import finish successfully. Asking for QAWANTED, since I'm not sure if we are trying this in the correct branch. Thanks.
Comment 14•11 years ago
|
||
Asking for qawanted, since I'll need to be sure we are reproducing this in version 1.1 not in master. Thanks!
Keywords: qawanted
Updated•11 years ago
|
QA Contact: mclemmons
Comment 15•11 years ago
|
||
In response to Comment 14, I am only able to reproduce the issue in version 1.1 on 1 of 2 occasions following the STR in Comment 0. The attempted import number was 821. The Environmental Variables for COMRil are listed below: Build ID: 20130828041203 Gecko: http://hg.mozilla.org/releases/mozilla-b2g18/rev/c3b4683d1360 Gaia: 518178ca234c98eb1ca0c0997b9d59faea640a85 Platform Version: 18.1 RIL Version: 01.01.00.019.205 firmware: d300f08o After initial failure then successfully importing 821 results, I attempted to import 1600 contacts on the same 1.1 build. The result was the device being locked on the screen after the Settings screen that the user can select Gmail. I flashed the phone four distinct times to the same 1.1 build listed above in this comment and was unable to get around the persistent message. Please hold on. We are connecting to obtain your friend list. Blue dots scrolling from left to right on the device appears below this message followed at the bottom with a cancel button. I tried flashing the device again to the same 1.1 build above to import the lesser 821 contacts again and the persistent message shows again. Restart the device and trying again to import has zero effect. Power off the device and trying again to import has zero effect.
Keywords: qawanted
Comment 16•11 years ago
|
||
@mclemmons, could you provide the test account? I've checked with test account from David Palomino, gaia 1.1 and works for me. Perhaps I could reproduce the problem and fix it with those credentials. Thanks
Flags: needinfo?(mclemmons)
Comment 17•11 years ago
|
||
@Francisco, emailed test account credentials in email.
Updated•11 years ago
|
Flags: needinfo?(mclemmons)
Comment 18•11 years ago
|
||
Thanks a lot!
Comment 19•11 years ago
|
||
(In reply to Preeti Raghunath(:Preeti) from comment #8) > Ivan > > Can we have access to the actual account in question? Already handled
Flags: needinfo?(itsay)
Comment 20•11 years ago
|
||
Mananged to reproduce, but it's not related to the gmail import, we do fecth all the contacts from the API correctly, but to the way we build the contact list for selecting which friends we want to import. Which means other importers like facebook or hotmail, with huge amount of users will fail as well. Not so sure if there is already a bug open for huge list of FB contacts. Ben, are you working on a bug close to this behavior I just commented?
Flags: needinfo?(bkelly)
Comment 21•11 years ago
|
||
(In reply to Francisco Jordano [:arcturus] from comment #20) > Mananged to reproduce, but it's not related to the gmail import, we do fecth > all the contacts from the API correctly, but to the way we build the contact > list for selecting which friends we want to import. > > Which means other importers like facebook or hotmail, with huge amount of > users will fail as well. > > Not so sure if there is already a bug open for huge list of FB contacts. > > Ben, are you working on a bug close to this behavior I just commented? Are you thinking of bug 892461? That is more about searching certain fields on FB contacts. We wanted to test the changes with a large amount of FB data, but I wasn't actually doing any changes to how we perform the import. So I think this is a separate bug. Maybe Cristian will have some input?
Flags: needinfo?(bkelly)
Updated•11 years ago
|
Whiteboard: [u=commsapps-user c=contacts p=0]
Comment 22•11 years ago
|
||
Flags: needinfo?(francisco.ramirez1)
Comment 23•11 years ago
|
||
Added the pending logs of my personal account with more than 800 contacts. This issue was reported by JuanPBF. After several attempts, doing default factory restore, I have seen that if you don't try to import the gmail contact in the start wizard, and you are in a good coverage conditions the import is finish properly. You can find enclosed 2 logs, one of them OK, the other NOK in order to compare.
Comment 24•11 years ago
|
||
Paco, So this is not an issue anymore? Please confirm.
Flags: needinfo?(francisco.ramirez1)
Assignee | ||
Updated•11 years ago
|
Assignee: francisco.jordano → jmcf
Assignee | ||
Comment 25•11 years ago
|
||
We have improved the rendering process and now the test user 'montoyaqatest' is working ok in v1-train. Nonetheless, I have to say that the provided user was very unrealistic as all the contacts were nearly under the same letter.
Assignee | ||
Comment 26•11 years ago
|
||
Proposed patch. Tested on unagi v1-train Gecko-61e302a and works with the provided test account.
Attachment #800087 -
Flags: review?(crdlc)
Attachment #800087 -
Flags: feedback?(francisco.jordano)
Comment 27•11 years ago
|
||
Comment on attachment 800087 [details]
11949.html
Good work and better idea! Please review some minor comment on Github. r+ from my side. Thanks a lot
Attachment #800087 -
Flags: review?(crdlc) → review+
Comment 28•11 years ago
|
||
Comment on attachment 800087 [details]
11949.html
Pretty amazing job, now much more robust to weird cases like this one.
Attachment #800087 -
Flags: feedback?(francisco.jordano) → feedback+
Assignee | ||
Comment 29•11 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/fed3a0f4eabef02a7af25b0081bcbdb582e9bd1e
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Comment 30•11 years ago
|
||
I was not able to uplift this bug to v1-train. If this bug has dependencies which are not marked in this bug, please comment on this bug. If this bug depends on patches that aren't approved for v1-train, we need to re-evaluate the approval. Otherwise, if this is just a merge conflict, you might be able to resolve it with: git checkout v1-train git cherry-pick -x -m1 fed3a0f4eabef02a7af25b0081bcbdb582e9bd1e <RESOLVE MERGE CONFLICTS> git commit
Flags: needinfo?(jmcf)
Assignee | ||
Comment 31•11 years ago
|
||
landed on v1-train https://github.com/mozilla-b2g/gaia/commit/ef10d7ef19064e8f9a2f07b8e8d2a0ebe5dc1343
Flags: needinfo?(jmcf)
Updated•11 years ago
|
status-b2g18:
--- → fixed
Comment 32•11 years ago
|
||
This was backed out with 9a1fdd0f9a9fb4141ab8170bcf156d081afb6c6a to see if it was the cause for breaking b2g18
Comment 33•11 years ago
|
||
Is there any progress?
Assignee | ||
Comment 34•11 years ago
|
||
John, As soon as we determine is not this bug's fault, please could you re-commit this change? It is a leo+ bug. thanks
Flags: needinfo?(jhford)
Comment 36•11 years ago
|
||
v1.1.0hd: 0a42b7af4346ac27a519569bc7ca39dd565e8cde v1.1.0hd: ef10d7ef19064e8f9a2f07b8e8d2a0ebe5dc1343
status-b2g-v1.1hd:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•