907186 - [FMRadio] Star isn't centered on the button

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::FMRadio, defect)

Description

[Amy Lee [:amylee] UX]

Attachment: Radio_App.png

Hi, 

The star isn't centered on the button. Can you please adjust the position? I've attached a screenshot.

Thanks

Comment 1

[Wayne Chang [:wchang]]

HD+ asset

Comment 2

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: After patch screenshot

Comment 3

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

Comment 4

[Amy Lee [:amylee] UX]

Comment on attachment 794165 [details]
After patch screenshot

Hi Pavel, 

Looks good. Thanks

Comment 5

[Sam Joch [:samjoch]]

Comment on attachment 794167 [details]
patch for Gaia/master

Landed in master: https://github.com/mozilla-b2g/gaia/commit/abde63f29546856c1ca843e4021cedc752d93ad0

Comment 6

[Sam Joch [:samjoch]]

There are conflicts when i tried to uplift to v1.1.0hd. Pavel can you handle it or pr v1.1.0hd branch ?

Comment 7

[Eric Pang [:epang] UX]

(In reply to Sam Joch [:samjoch] from comment #6)
> There are conflicts when i tried to uplift to v1.1.0hd. Pavel can you handle
> it or pr v1.1.0hd branch ?

Hey Pavel, have you had a chance to look into this? Thanks!

Comment 8

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Landed to v1.1.0hd:
abb51b27f5b6748fefda23c0d4047fe1fe72b628

Comment 9

[William Hsu [:whsu]]

Thanks for your help!

Verified it on following build. Attaching screenshot.

Test Build:
- PVT Build: Mozilla-b2g18_v1_1_0_hd-helix/2013-09-03-04-22-01
- Gecko revision="dc78e5642c44"
- Gaia revision="d3e3d1e29dc52f038a6cb69a91b57d6cc2622955"
- Gecko version: 26.0a1

Comment 10

[William Hsu [:whsu]]

Attachment: FM- Favorite icon