[Everything.me] Clear icon looks like still in SD or outdated

VERIFIED FIXED

Status

VERIFIED FIXED
5 years ago
5 years ago

People

(Reporter: amylee, Assigned: pivanov)

Tracking

unspecified
All
Gonk (Firefox OS)

Firefox Tracking Flags

(blocking-b2g:hd+, b2g-v1.1hd fixed)

Details

(Whiteboard: sverd vsd, HD, HD)

Attachments

(4 attachments)

(Reporter)

Description

5 years ago
Hi, 

The clear icon doesn't look right (might be outdated or still in SD). It should be the same clear icon used throughout the device for text fields (ie. add new contact text fields).

Thanks
(Reporter)

Comment 1

5 years ago
Created attachment 792838 [details]
Search - Clear Button.png

Screenshot for reference.
(Reporter)

Updated

5 years ago
Summary: [FMRadio] Star isn't centered on the button → [Everything.me] Clear icon looks like still in SD or outdated
HD+ asset
blocking-b2g: --- → hd+
Created attachment 793313 [details]
After patch screenshot
Attachment #793313 - Flags: feedback?(amylee.design)
Created attachment 793314 [details]
patch for Gaia/v1.1.0hd
(Reporter)

Comment 5

5 years ago
Comment on attachment 793313 [details]
After patch screenshot

Hi Pavel, 

Looks good to me. Thanks!
Attachment #793313 - Flags: feedback?(amylee.design) → feedback+
Whiteboard: helix vsd → sverd vsd
Whiteboard: sverd vsd → sverd vsd, HD
Whiteboard: sverd vsd, HD → sverd vsd, HD, HD
Attachment #793314 - Flags: review?(sjochimek)
Comment on attachment 793314 [details]
patch for Gaia/v1.1.0hd

Landed in v1.1.0hd: https://github.com/mozilla-b2g/gaia/commit/c0ea0a4943dc8d3751b07f5b5c5d3abe06364a14
Attachment #793314 - Flags: review?(sjochimek) → review+

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
status-b2g-v1.1hd: --- → fixed
Resolution: --- → FIXED
Thanks! Verified this patch.

* Test build:(Mozilla Central-helix/2013-08-25-04-22-01)
  + Mercurial-Information
    - Gecko revision="f392714dea0b"
  + Git-information
    - Gaia revision="7b61b7dc3400d5bea23d2b52948f4fded8259dfc"


Attaching the screenshot. Marked as verified.
Status: RESOLVED → VERIFIED
Created attachment 796002 [details]
Clear icon
You need to log in before you can comment on or make changes to this bug.