907211 - [MP] Defect - Downloads not working (no UI displayed), console reports "Strings is not defined" in HelperAppDialog.js

Status: VERIFIED FIXED

(Firefox for Metro Graveyard :: Downloads, defect, P2)

Description

[Francesco Lodolo [:flod]]

When I try to download something from Firefox Metro, I click on a link, I see a quick animation on the bottom blue/gray line, the navigation bar appears but nothing else. In my Downloads folder I found only .part files, this error is reported in the console:

Error: Strings is not defined
resource://app/components/HelperAppDialog.js
Line: 45

I'm currently using a localized build (2013-08-19), but I had the same problem with an en-US build.

Comment 1

[Jim Mathies [:jimm]]

http://mxr.mozilla.org/mozilla-central/source/browser/metro/components/HelperAppDialog.js#45

Is Strings.browser not available in components?

Comment 2

[Sam Foster [:sfoster] (he/him)]

I've got this covered in a patch on bug 893091. I can break it out associate it with this ticket though.

Comment 3

[Sam Foster [:sfoster] (he/him)]

Attachment: Fix localized string access for download size

There's no Strings global in this component, this patch create a localized message bundle and get the downloadsUnknownSize from it (same pattern as used elsewhere in the file)

Comment 4

[Allison Naaktgeboren :ally]

Comment on attachment 793014 [details] [diff] [review]
Fix localized string access for download size

Review of attachment 793014 [details] [diff] [review]:
-----------------------------------------------------------------

I'm not sure you really need me for this. :) ship it

Comment 5

[Sam Foster [:sfoster] (he/him)]

On fx-team: 
 https://hg.mozilla.org/integration/fx-team/rev/639899ea2f57

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/639899ea2f57

Comment 7

[Manuela Muntean [Away]]

Mozilla/5.0 (Windows NT 6.2; WOW64; rv:26.0) Gecko/20100101 Firefox/26.0
Build ID: 20130827030201

WFM
Tested on both Windows 8 32bit and 64bit using latest Nightly for iteration #13 and following the indications from comment 0. The download worked as expected (with UI shown), no .part files and no error reported in the console.

Comment 8

[Manuela Muntean [Away]]

Attachment: screenshot.png

This works with the latest Nightly (build ID: 20130915030208) (while testing it for iteration #14), but I've encountered the next issue:

- while downloading an .exe from http://ftp.mozilla.org/pub/mozilla.org/firefox/nightly/24.0b10-candidates/build1/win32/en-US/ , the file downloaded as expected, but the blue ring around the download button is only half filled 

Please see the attached screenshot for details.

Does anyone have any suggestions/thoughts? Thanks!

Comment 9

[Sam Foster [:sfoster] (he/him)]

Manuela, can you create a new issue for this if you can still reproduce it with the latest nightly? We have worked through some problems with the downloads progress ring so this might be covered in an existing ticket, but if you're unsure, file the bug and we'll figure it out.

Comment 10

[Manuela Muntean [Away]]

(In reply to Sam Foster [:sfoster] from comment #9)
> Manuela, can you create a new issue for this if you can still reproduce it
> with the latest nightly? We have worked through some problems with the
> downloads progress ring so this might be covered in an existing ticket, but
> if you're unsure, file the bug and we'll figure it out.

Everything works as expected now, with the latest Nightly (build ID: 20130918030202) on a Win 8 32-bit machine. I can't reproduce the issue anymore.