Closed
Bug 907212
Opened 11 years ago
Closed 11 years ago
Webmaker.org uses old styling for "search" results, compared to the "my makes" styling
Categories
(Webmaker Graveyard :: X-Ray Goggles, defect)
Webmaker Graveyard
X-Ray Goggles
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: jon, Assigned: michiel)
Details
Attachments
(1 file)
When you visit webmaker.org and click the remix button ( https://webmaker.org/en-US/search?type=all&q=mopaxian ) you'll get a nice 404 page ( http://mopaxian.makes.org/goggles/mopaxians-remix-of-mopaxians-remix-of-nrcnl-snelle-duiding-bij-het-belangrijkste-nieuws/remix ) The problem here is that Goggles doesn't support remixing like Popcorn and Thimble do, it only supports in-page remixing. I think as a short-term solution we should disable the Remix button on Goggles makes, and as a long-term solution we should write a Goggles editor like Popcorn and Thimble.
Reporter | ||
Updated•11 years ago
|
Summary: Goggles don't support remixing from webmaker.org → Goggles doesn't support remixing from webmaker.org
I thought I removed the remix button for goggles makes, so I'll have to look at what happened/happens here to make it show up
Assignee: nobody → pomax
Status: NEW → ASSIGNED
morphing prior to attaching patch.
Summary: Goggles doesn't support remixing from webmaker.org → Webmaker.org uses old styling for "search" results, compared to the "my makes" styling
Attachment #8334842 -
Flags: review?(dale)
Comment 4•11 years ago
|
||
Comment on attachment 8334842 [details] [review] https://github.com/mozilla/webmaker.org/pull/508 - Travis fails... over beautification? That is new to me. - CSS changes result in ugliness in other areas of site where those css classes are used (example: https://dl.dropboxusercontent.com/s/9h5y1vlwjaljzvx/2013-11-20%20at%2012.00%20PM.png) - weird fork button movement stuff, but I can help with that In terms of what the patch is supposed to functionally do, it works! :)
Attachment #8334842 -
Flags: review?(dale) → review-
Comment on attachment 8334842 [details] [review] https://github.com/mozilla/webmaker.org/pull/508 update so the CSS doesn't interfere. grunt passes as far as I can tell, as for the pixel wibble... that might have to be its own ticket, it was already in effect before this one, and this one should probably not try to to fix it
Attachment #8334842 -
Flags: review- → review?(dale)
Updated•11 years ago
|
Attachment #8334842 -
Flags: review?(dale) → review+
Comment 6•11 years ago
|
||
Commit pushed to master at https://github.com/mozilla/webmaker.org https://github.com/mozilla/webmaker.org/commit/4fc9e820b6bf24bc38a3778709b4c1b5c64b7df9 Merge pull request #508 from Pomax/bug907212 homogenize UI for search makes and "my makes" makes
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•