Webmaker.org uses old styling for "search" results, compared to the "my makes" styling

RESOLVED FIXED

Status

Webmaker
X-Ray Goggles
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: jbuck, Assigned: pomax)

Tracking

Details

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
When you visit webmaker.org and click the remix button ( https://webmaker.org/en-US/search?type=all&q=mopaxian ) you'll get a nice 404 page ( http://mopaxian.makes.org/goggles/mopaxians-remix-of-mopaxians-remix-of-nrcnl-snelle-duiding-bij-het-belangrijkste-nieuws/remix )

The problem here is that Goggles doesn't support remixing like Popcorn and Thimble do, it only supports in-page remixing.

I think as a short-term solution we should disable the Remix button on Goggles makes, and as a long-term solution we should write a Goggles editor like Popcorn and Thimble.
(Reporter)

Updated

4 years ago
Summary: Goggles don't support remixing from webmaker.org → Goggles doesn't support remixing from webmaker.org
(Assignee)

Comment 1

4 years ago
I thought I removed the remix button for goggles makes, so I'll have to look at what happened/happens here to make it show up
Assignee: nobody → pomax
Status: NEW → ASSIGNED
(Assignee)

Comment 2

4 years ago
morphing prior to attaching patch.
Summary: Goggles doesn't support remixing from webmaker.org → Webmaker.org uses old styling for "search" results, compared to the "my makes" styling
(Assignee)

Comment 3

4 years ago
Created attachment 8334842 [details] [review]
https://github.com/mozilla/webmaker.org/pull/508
Attachment #8334842 - Flags: review?(dale)

Comment 4

4 years ago
Comment on attachment 8334842 [details] [review]
https://github.com/mozilla/webmaker.org/pull/508

- Travis fails... over beautification? That is new to me.
- CSS changes result in ugliness in other areas of site where those css classes are used (example: https://dl.dropboxusercontent.com/s/9h5y1vlwjaljzvx/2013-11-20%20at%2012.00%20PM.png)
- weird fork button movement stuff, but I can help with that

In terms of what the patch is supposed to functionally do, it works! :)
Attachment #8334842 - Flags: review?(dale) → review-
(Assignee)

Comment 5

4 years ago
Comment on attachment 8334842 [details] [review]
https://github.com/mozilla/webmaker.org/pull/508

update so the CSS doesn't interfere. grunt passes as far as I can tell, as for the pixel wibble... that might have to be its own ticket, it was already in effect before this one, and this one should probably not try to to fix it
Attachment #8334842 - Flags: review- → review?(dale)

Updated

4 years ago
Attachment #8334842 - Flags: review?(dale) → review+

Comment 6

4 years ago
Commit pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/4fc9e820b6bf24bc38a3778709b4c1b5c64b7df9
Merge pull request #508 from Pomax/bug907212

homogenize UI for search makes and "my makes" makes
(Assignee)

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.