Closed Bug 907228 Opened 12 years ago Closed 9 years ago

GC: SharedScriptData should have a destructor, and other tidyup

Categories

(Core :: JavaScript Engine, defect)

Product:
Core
Component:
JavaScript Engine
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WONTFIX

People

(Reporter: jonco, Assigned: jonco)

Details

Following bug 893184, SharedScriptData should probably have a destructor. I tried to add this in the original bug, but it caused crashes. This needs investigating. Also, Till suggested the following improvements: > I wonder if we should turn JSScript->natoms and maybe ->length into getters that consult the SharedScriptData. natoms is only used in a few places, with markChildren being the only perf-critical one.
It doesn't seem that there's much point doing this. The only thing a destructor would do is call the GCAtomPtr destructor for the atoms, and that doesn't do anything in release builds anyway. The refactoring suggestion has been dealt with elsewhere.
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.