907260 - [SMS] Wrong "Add Recipient" icon

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::SMS, defect, P1)

Description

[Amy Lee [:amylee] UX]

Attachment: sms_add_recipient_icons.zip

Hi, 

The "add recipient" icon is incorrect for SD and HD devices. Can you please replace them with the attached graphics?  

Thanks

Comment 1

[Amy Lee [:amylee] UX]

Attachment: screenshot.png

Screenshot for reference

Comment 2

[Wayne Chang [:wchang]]

HD+ asset

Comment 3

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

We need also active states of the icons:
https://github.com/mozilla-b2g/gaia/blob/master/apps/sms/style/images/add_contact.png

https://github.com/mozilla-b2g/gaia/blob/master/apps/sms/style/images/add_contact%401.5x.png

Comment 4

[Eric Pang [:epang] UX]

Attachment: add contact icon

Pavel, here are the icons with active states.  Let me know if anything else is needed :).

Amy, I've also updated the 1.5 psd you have on box.

Comment 5

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Attachment: patch for Gaia/master

Comment 6

[Sam Joch [:samjoch]]

Comment on attachment 794149 [details]
patch for Gaia/master

Landed in master: https://github.com/mozilla-b2g/gaia/commit/271810e41a4ab6ef513b192e8a0762e62cbab308

Comment 7

[Eric Pang [:epang] UX]

(In reply to Sam Joch [:samjoch] from comment #6)
> Comment on attachment 794149 [details]
> patch for Gaia/master
> 
> Landed in master:
> https://github.com/mozilla-b2g/gaia/commit/
> 271810e41a4ab6ef513b192e8a0762e62cbab308

Sam, will this also be landing in HD?

Comment 8

[Sam Joch [:samjoch]]

Landed in v1.1.0hd: https://github.com/mozilla-b2g/gaia/commit/ee4ed2b561152ea3d5f597f05c023e7f7671c625

Comment 9

[William Hsu [:whsu]]

Thank you!

Verified it on following build. Attaching screenshot.

Test Build:
- PVT Build: Mozilla-b2g18_v1_1_0_hd-helix/2013-09-03-04-22-01
- Gecko revision="dc78e5642c44"
- Gaia revision="d3e3d1e29dc52f038a6cb69a91b57d6cc2622955"
- Gecko version: 26.0a1

Comment 10

[William Hsu [:whsu]]

Attachment: Message app - Add icon