907268 - Each access to same observable objects are wrapped with distinct wrappers

Status: RESOLVED FIXED

(DevTools Graveyard :: WebIDE, defect)

Description

[Alexandre Poirot [:ochameau]]

Anytime we access an observable object attribute that is an object, we end up creating a new proxy for this object.

Comment 1

[Alexandre Poirot [:ochameau]]

Attachment: Each access to same observable objects are wrapped with distinct wrappers

Comment 2

[Alexandre Poirot [:ochameau]]

Comment on attachment 792912 [details] [diff] [review]
Each access to same observable objects are wrapped with distinct wrappers

No idea if that a nice way to address this issue, but it do fix it :p

Comment 3

[Paul Rouget [:paul]]

Comment on attachment 792912 [details] [diff] [review]
Each access to same observable objects are wrapped with distinct wrappers

Alex, can you add a string to the is()?

Brandon, can you look at this?

Comment 4

[Brandon Benvie [:benvie]]

Comment on attachment 792912 [details] [diff] [review]
Each access to same observable objects are wrapped with distinct wrappers

Review of attachment 792912 [details] [diff] [review]:
-----------------------------------------------------------------

This looks good. I would just caution that this might make it harder for wrapped objects to be GCed, since there's now a two way reference between the wrapper and the value. It might be good to have a way method to dispose of an observable object (`this._values = this._wrappers = this._paths = null` or something) although I don't know how much a user of this is looking for memory efficiency.

Comment 5

[Alexandre Poirot [:ochameau]]

Attachment: Wrap observable objects with singleton wrappers.

I just added a message in the is() assertion.

Comment 6

[Paul Rouget [:paul]]

https://hg.mozilla.org/integration/fx-team/rev/4daa96d66d16

Comment 7

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/4daa96d66d16