907286 - Implement Frame Counter API for non OMTC basic

Status: RESOLVED FIXED

(Core :: Graphics, defect)

Description

[Benoit Girard (:BenWa)]

fx-team would like to use the profiler to get a frame-sync profiles on non OMTC basic. This will be easy to port.

Comment 1

[Benoit Girard (:BenWa)]

Attachment: WIP

This patch doesn't work on mac because we only copy back the portion of the frame buffer we need back to the window. Can you see if this work on win?

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Didn't mean to wipe out the needinfo on myself.

Comment 4

[Benoit Girard (:BenWa)]

Attachment: patch

Comment 5

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 794106 [details] [diff] [review]
patch

Review of attachment 794106 [details] [diff] [review]:
-----------------------------------------------------------------

The Graphics parts are fine.

Comment 6

[Benoit Girard (:BenWa)]

Comment on attachment 794106 [details] [diff] [review]
patch

tn can you review the nsViewManager part?

Comment 7

[Timothy Nikkel (:tnikkel)]

Comment on attachment 794106 [details] [diff] [review]
patch

Where's the definition of DrawFrameCounter?

Comment 8

[Benoit Girard (:BenWa)]

(In reply to Timothy Nikkel (:tn) from comment #7)
> Comment on attachment 794106 [details] [diff] [review]
> patch
> 
> Where's the definition of DrawFrameCounter?

http://mxr.mozilla.org/mozilla-central/source/gfx/thebes/gfxPlatform.cpp#1211

Comment 9

[Timothy Nikkel (:tnikkel)]

Comment on attachment 794106 [details] [diff] [review]
patch

Oh, silly me. I misread the patch and thought you were adding the declaration of DrawFrameCounter in this patch, which you aren't.

Comment 10

[Benoit Girard (:BenWa)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/b66681223e7c

Comment 11

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b66681223e7c