907289 - Trace client should always emit "enteredFrame" and "exitedFrame" events in sequence order

Status: RESOLVED FIXED

(DevTools :: General, defect)

Description

[Jake Bailey]

enteredFrame and exitedFrame packets contain a sequence number, since building up a call tree depends on the ordering of these packets, and we don't want to rely on the fact that packets are currently always received from the server in the order they were sent.

Currently, enteredFrame and exitedFrame events are emitted by the trace client whenever a packet is received. If we can't rely on receiving the packets in order, the client should queue unexpected packets and wait for the next in the sequence.

Comment 1

[Jake Bailey]

Attachment: Patch

Comment 2

[Jake Bailey]

Try push: https://tbpl.mozilla.org/?tree=Try&rev=afd89acb02d0

Comment 3

[Jake Bailey]

Attachment: Patch

Just missed a function rename and forgot to do a qrefresh before uploading the patch. The try push is using this version of the patch.

Comment 4

[Jake Bailey]

Attachment: Patch

I ran some tests and it turns out shift is a lot slower than I thought it was (thought there was some behind-the-scenes index math making it comparable to pop, but there isn't). This patch uses a Map instead.

Try push: https://tbpl.mozilla.org/?tree=Try&rev=fb1ddc18e523

Comment 5

[Paul Rouget [:paul]]

https://hg.mozilla.org/integration/fx-team/rev/b968cfd447a0

Comment 6

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/b968cfd447a0