Closed Bug 907289 Opened 8 years ago Closed 8 years ago
Trace client should always emit "entered
Frame" and "exited Frame" events in sequence order
enteredFrame and exitedFrame packets contain a sequence number, since building up a call tree depends on the ordering of these packets, and we don't want to rely on the fact that packets are currently always received from the server in the order they were sent. Currently, enteredFrame and exitedFrame events are emitted by the trace client whenever a packet is received. If we can't rely on receiving the packets in order, the client should queue unexpected packets and wait for the next in the sequence.
Just missed a function rename and forgot to do a qrefresh before uploading the patch. The try push is using this version of the patch.
I ran some tests and it turns out shift is a lot slower than I thought it was (thought there was some behind-the-scenes index math making it comparable to pop, but there isn't). This patch uses a Map instead. Try push: https://tbpl.mozilla.org/?tree=Try&rev=fb1ddc18e523
Attachment #793172 - Flags: review?(nfitzgerald) → review+
Assignee: nobody → rbailey
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 26
You need to log in before you can comment on or make changes to this bug.