If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Solution static strings list of languages in wikipedia plugin

RESOLVED FIXED

Status

Webmaker
Popcorn Maker
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: alicoding, Assigned: alicoding)

Tracking

Details

Attachments

(1 attachment)

(Assignee)

Description

4 years ago
Wikipedia plugin has a list of languages which we agreed that this shouldn't be include in messages.json and not for the translator to translate them. We can make it static and put them back in the plugin page.
(Assignee)

Updated

4 years ago
Status: NEW → ASSIGNED
QA Contact: ali
(Assignee)

Comment 1

4 years ago
Created attachment 801701 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/196
Attachment #801701 - Flags: review?(schranz.m)
Assignee: nobody → ali
QA Contact: ali
Comment on attachment 801701 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/196

R+ with nits.
Attachment #801701 - Flags: review?(schranz.m) → review+

Comment 3

4 years ago
Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org

https://github.com/mozilla/popcorn.webmaker.org/commit/cec40c1263e9916c74c0fa5b20bf119abc03689c
bug907360 - static language wikipedia
(Assignee)

Updated

4 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.