XBL constructors are shown as Anonymous functions in profiles

RESOLVED FIXED in mozilla26

Status

()

--
enhancement
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: MattN, Assigned: Gavin)

Tracking

Trunk
mozilla26
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

It would be useful to indicate that it's a constructor and provide the id of the binding.

Profile snippet:
{"line": 2908, "location": " (chrome://browser/content/tabbrowser.xml:2886)"},
Created attachment 793803 [details] [diff] [review]
patch

This seems to work. I chose "<bindingID>_XBL_[Con|De]structor" as the function name, anyone have better suggestions?
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
Attachment #793803 - Flags: review?(bzbarsky)
Component: Gecko Profiler → XBL
Comment on attachment 793803 [details] [diff] [review]
patch

I think you need to bump XBLBinding_Serialize_Version.

r=me with that
Attachment #793803 - Flags: review?(bzbarsky) → review+
https://hg.mozilla.org/mozilla-central/rev/9a7ec412009b
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.