Closed
Bug 907430
Opened 12 years ago
Closed 12 years ago
XBL constructors are shown as Anonymous functions in profiles
Categories
(Core :: XBL, enhancement)
Core
XBL
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: MattN, Assigned: Gavin)
Details
Attachments
(1 file)
|
7.33 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
It would be useful to indicate that it's a constructor and provide the id of the binding.
Profile snippet:
{"line": 2908, "location": " (chrome://browser/content/tabbrowser.xml:2886)"},
|
Assignee | |
Comment 1•12 years ago
|
||
This seems to work. I chose "<bindingID>_XBL_[Con|De]structor" as the function name, anyone have better suggestions?
Assignee: nobody → gavin.sharp
Status: NEW → ASSIGNED
|
|
Assignee | |
Updated•12 years ago
|
Attachment #793803 -
Flags: review?(bzbarsky)
|
|
Assignee | |
Updated•12 years ago
|
Component: Gecko Profiler → XBL
|
||
Comment 2•12 years ago
|
||
Comment on attachment 793803 [details] [diff] [review]
patch
I think you need to bump XBLBinding_Serialize_Version.
r=me with that
Attachment #793803 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
Try push: https://tbpl.mozilla.org/?tree=Try&rev=aa8238a0a09c
Landed on fx-team: https://hg.mozilla.org/integration/fx-team/rev/9a7ec412009b
Target Milestone: --- → mozilla26
|
||
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•