907481 - Check if localId is already used before using it

Status: RESOLVED FIXED

(Firefox Graveyard :: Web Apps, defect)

Description

[Marco Castelluccio [:marco]]

Attachment: localid_fix

To get a new localId, we're using a preference. This doesn't work well with the multiple profile model we have for desktop apps.

Comment 1

[[:fabrice] Fabrice Desré]

Can you give steps to reproduce the issue you're having? I can't tell if this is in the app profile or in the firefox profile, and what are the prefs in any of them.

Comment 2

[Marco Castelluccio [:marco]]

The Firefox profile and the webapps profiles are separated.

e.g. in Firefox, the preference could be 1000, in one of the installed webapps it could be 1.
If you install an app through Firefox, _nextLocalId returns 1001.
If you install an app through another app, _nextLocal returns 2. This localId=2 could be already used by another application.

So, we can't rely on a preference because it isn't guaranteed to be in a sane state.

Comment 3

[[:fabrice] Fabrice Desré]

That doesn't explain why you want to avoid collisions between the firefox profile and the app profile.

I don't think you should try to synchronize the localIds among profiles. They are an implementation detail due to how we identify apps in principals and data jars. What really matters is only the manifest url.

Comment 4

[Marco Castelluccio [:marco]]

(In reply to Fabrice Desré [:fabrice] from comment #3)
> That doesn't explain why you want to avoid collisions between the firefox
> profile and the app profile.

The apps installed through another app are still installed in the Firefox profile. So without this patch we'd end up with several apps installed with the same localId in the same profile.

Comment 5

[Marco Castelluccio [:marco]]

We should disable apps installation from the webapp runtime if we can't fix this.

Comment 6

[Marco Castelluccio [:marco]]

Attachment: localid_fix

Updated commit message.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/b2g-inbound/rev/dc5a610965b0

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/dc5a610965b0