907547 - Remove unnecessary null-checks of nsCSSValue::BufferFromString()'s return value

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, defect)

Description

[Daniel Holbert [:dholbert]]

Most callers of nsCSSValue::BufferFromString() null-check its return value, because it used to be fallible.

However, bug 659963 changed it to be infallible -- in particular, it made us abort if nsStringBuffer::Alloc() fails.[1]

That bug's patch remove a null-check from one BufferFromString caller[2], but it left behind others. Filing this bug on removing null-checks from the other callers.

[1] http://hg.mozilla.org/mozilla-central/rev/67673422f7d2#l6.40
[2] http://hg.mozilla.org/mozilla-central/rev/67673422f7d2#l1.633

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: fix v1

Comment 2

[Daniel Holbert [:dholbert]]

For reference, here's a link to the nsCSSValue::BufferFromString() impl:
http://mxr.mozilla.org/mozilla-central/source/layout/style/nsCSSValue.cpp?rev=dbc04a661a1a&mark=627-629,635-637#622
...with its internal null-checks highlighted, which show that there's no way for that function to return null.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 793326 [details] [diff] [review]
fix v1

r=me

Comment 4

[Daniel Holbert [:dholbert]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a8ac722352c8

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/a8ac722352c8