90755 - add includes and excludes to jprof

Status: RESOLVED FIXED

(SeaMonkey :: General, defect, P1)

Description

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

See the very simple patch below to add includes (-i) and excludes (-e) to jprof.
 The way I interpreted the meaning of the vestigial command line options was
that -i means that you only want to count stacks that include the given frame in
the stack, -e means that you only want to count stacks that don't have that
frame in the stack, and when combined -e overrides -i.  I think that's how the
existing code in leaky was intended.  Anyway, I'd like to check this in...

Index: leaky.cpp
===================================================================
RCS file: /cvsroot/mozilla/tools/jprof/leaky.cpp,v
retrieving revision 1.5
diff -u -d -r1.5 leaky.cpp
--- leaky.cpp   2001/02/16 01:36:58     1.5
+++ leaky.cpp   2001/07/13 23:38:08
@@ -481,6 +481,9 @@
   for(malloc_log_entry* lep=firstLogEntry; 
     lep < lastLogEntry;
     lep = reinterpret_cast<malloc_log_entry*>(&lep->pcs[lep->numpcs])) {
+
+    if (excluded(lep) || !included(lep))
+      continue;
 
     ++stacks; // How many stack frames did we collect


Looking for review / super-review...

Comment 1

[jim_nance]

Looks good to me.  Thanks for working on this.  r=[e-mail]

Comment 2

[Chris Waterson]

sr=waterson

Comment 3

[David Baron :dbaron: (⌚️UTC-5, no longer working on Mozilla)]

Checked in 2001-07-16 13:44 PDT.