907579 - [Buri][FOTA] The option "Share using USB" is being turned off after upgrading

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: General, defect, P2)

Description

[sync-1]

Created an attachment (id=468420)
 0724
 
 DEFECT DESCRIPTION:
 The option "Share using USB" is not turned on by default.
 
 REPRODUCING PROCEDURES:
 1.Download diff package,and install it,it will upgrade succeed.
 2.Then settings->Media storage->find the option "Share using USB" is not turned on by default. --KO
 
 Note:
 Down the version from teleweb,the option "Share using USB" is turned on by default.
  
 EXPECTED BEHAVIOUR:
 The option "Share using USB" is turned on by default.
 
 ASSOCIATE SPECIFICATION:
 
 TEST PLAN REFERENCE:
 
 TOOLS AND PLATFORMS USED:
 
 USER IMPACT:
 Medium
 
 REPRODUCING RATE:
 3/3
 
 For FT PR, Please list reference mobile's behavior:
 
 
 I think DB change from 1.0 to 1.1.

Comment 1

[sync-1]

Clone from brother

Comment 2

[sync-1]

Attachment: 493744-adblog

Comment 3

[sync-1]

Clone from brother

Comment 4

[sync-1]

Attachment: 0724

Comment 5

[Viga]

This leads to USB connection function unusable.

Comment 6

[Preeti Raghunath(:Preeti)]

Tim,

Please check this issue as it seems to be a GAIA issue.

Comment 7

[Viga]

It's an IndexDB issue actually. 
SettingsDB in v1.0.1 is "2"  same with the version in v1.1
upgradeSchema isn't triggered.
Unless user reset data to trigger upgradeSchema again.

I think we are in the dilemma.

Comment 8

[Tim Guan-tin Chien [:timdream] (please needinfo)]

UMS is not enabled by default in either v1.0.1 nor v1.1 and we shouldn't turn on USB sharing secretly when upgrading. 

https://github.com/mozilla-b2g/gaia/blob/v1.0.1/build/settings.py
https://github.com/mozilla-b2g/gaia/blob/v1-train/build/settings.py

Comment 9

[Viga]

Think this way, I'm using v1.0.1 phone, which I turned on intentionally. After upgrade the system.
It's changing my intention. USB connection is off.

Comment 10

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Can QA reproduce this in our open sourced Gaia/Gecko? Can we reproduce this bug on devices other than Buri?

Comment 11

[Viga]

As I said per comments 7#. I can surely say yes.

Comment 12

[Preeti Raghunath(:Preeti)]

moving to koi? It is very very late to land anything to leo.

Comment 13

[Gregor Wagner [:gwagner]]

(In reply to weijia from comment #9)
> Think this way, I'm using v1.0.1 phone, which I turned on intentionally.
> After upgrade the system.
> It's changing my intention. USB connection is off.

This shouldn't happen. We store a default Value and a user Value in the settingsDB.
When we read from the DB we always return the user Value before the default Value.
When we upgrade the DB, we only overwrite the default Value so we never overwrite the user intention.

Comment 14

[Viga]

(In reply to Gregor Wagner [:gwagner] from comment #13)
> This shouldn't happen. We store a default Value and a user Value in the
> settingsDB.
> When we read from the DB we always return the user Value before the default
> Value.
> When we upgrade the DB, we only overwrite the default Value so we never
> overwrite the user intention.
You mentioned upgrade the DB. Actually we don't have chance to upgrade DB. The 
DB versions are the same. The upgradeSchema isn't called.

Comment 15

[Gregor Wagner [:gwagner]]

(In reply to weijia from comment #14)
> (In reply to Gregor Wagner [:gwagner] from comment #13)
> > This shouldn't happen. We store a default Value and a user Value in the
> > settingsDB.
> > When we read from the DB we always return the user Value before the default
> > Value.
> > When we upgrade the DB, we only overwrite the default Value so we never
> > overwrite the user intention.
> You mentioned upgrade the DB. Actually we don't have chance to upgrade DB.
> The 
> DB versions are the same. The upgradeSchema isn't called.

So what's the problem here if we don't overwrite a setting?

Comment 16

[Viga]

On v1.0.1 only one option needs to turned on to enable usb storage connection.
After upgrade to v1.1 there are two options addition with "Share using USB", which is turned
off on default, to enable USB storage connection. 
User may confuse that the connection doesn't function.

Comment 17

[Gregor Wagner [:gwagner]]

(In reply to weijia from comment #16)
> On v1.0.1 only one option needs to turned on to enable usb storage
> connection.
> After upgrade to v1.1 there are two options addition with "Share using USB",
> which is turned
> off on default, to enable USB storage connection. 
> User may confuse that the connection doesn't function.

I see. So we should just increment the DB version. This will load settings.json and add the missing settings.

Comment 18

[Viga]

Yes, but we can't fixed this on v1.1.  Or we can re-discuss the DB version strategy.
The DB version number too close that we can't have any chance to use the number between.
For example, v1.1 --> v1.2  the DB version from 2  --> 6  we have some chance to use 3,4,5 to fix
some DB upgrade issue.

Comment 19

[Gregor Wagner [:gwagner]]

(In reply to weijia from comment #18)
> Yes, but we can't fixed this on v1.1.  Or we can re-discuss the DB version
> strategy.
> The DB version number too close that we can't have any chance to use the
> number between.
> For example, v1.1 --> v1.2  the DB version from 2  --> 6  we have some
> chance to use 3,4,5 to fix
> some DB upgrade issue.

That is a good idea but we have to be really careful that we don't change the internal DB format with such a minor update. Changing the format with a minor update like 1.1.1 would be horrible to manage once we upgrade to 1.2.

So for the settingsDB case where we only load a new json file and add/modify/delete some default values for settings the revision gap should work.

Comment 20

[Hubert Lu[:hlu] <[e-mail]>]

Hi,
  I could not find "Share using USB" option under Media storage in my unagi v1.0.1 and Buri/Hamachi v1.0.1. Who could mention the detail build information for QA? Thanks!

   Unagi build information:
     Gaia:     054cdc27404e2daca91d3065d9783681032b2151
     Gecko:    http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/9c62297d11b0
     BuildID   20130906043205
     Version   18.0

   Buri/Hamachi build information:
     Gaia:     054cdc27404e2daca91d3065d9783681032b2151                         
     Gecko:    http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/9c62297d11b0       
     BuildID   20130906043205                                                   
     Version   18.0

Comment 21

[Viga]

(In reply to hlu from comment #20)
> Hi,
>   I could not find "Share using USB" option under Media storage in my unagi
> v1.0.1 and Buri/Hamachi v1.0.1. Who could mention the detail build
> information for QA? Thanks!
> 
>    Unagi build information:
>      Gaia:     054cdc27404e2daca91d3065d9783681032b2151
>      Gecko:   
> http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/9c62297d11b0
>      BuildID   20130906043205
>      Version   18.0
> 
>    Buri/Hamachi build information:
>      Gaia:     054cdc27404e2daca91d3065d9783681032b2151                     
> 
>      Gecko:   
> http://hg.mozilla.org/releases/mozilla-b2g18_v1_0_1/rev/9c62297d11b0       
>      BuildID   20130906043205                                               
> 
>      Version   18.0

This option is for v1.1 Can't be find on v1.0.1. 
This is all about upgrade from v1.0.1 to v1.1 via FOTA.

Comment 22

[Askeing Yen[:askeing][:fyen]]

base on comment 7 and comment 11, remove qawanted.

Comment 23

[Gregor Wagner [:gwagner]]

Another (and probably better) idea is to load settings.json whenever we upgrade gaia. So check for the buildID and load the new file when an upgrade occurred. This saves us from the revision number chaos.

Comment 24

[Preeti Raghunath(:Preeti)]

Minus based on triage. The upgrade from 1.0.1 to 1.1 had the default setting off.

The UX seems low here.

Comment 25

[Dave Hylands [:dhylands]]

The default setting of remote debugging is intentionally off.

Also, since bug 874484 landed, adb gets turned off after 12 hours anyways.

Comment 26

[BMO Automation]

Firefox OS is not being worked on