907581 - [B2G][Helix][sms][zhaotao]phone number can not be recognized in some cases

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::SMS, defect, P3)

Description

[lecky]

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E; aff-kingsoft-ciba; Zune 4.7)

Steps to reproduce:

1.use another phone to send sms:00123123123![phone]#123-123123
Test(123)123123123 to ffos phone
2.open the sms and check the phone number that can be recognized


Actual results:

in step 2,only 00123123123，(123)123123 can be recognized



Expected results:

00123123123，+123123123，123-123123，(123)123123 should all be recognized

Comment 1

[Gene Lian (I already quit Mozilla)]

Looping Gaia folks.

Comment 2

[Julien Wajsberg [:julienw]]

does this work on Android and iphone ?

recognizing numbers is hard, you know.

Comment 3

[Victor]

Phone: ZTE phone.
Firmware: V1.01.00.01.019.120

Same problem.
Moreover, it is inconsistent.
Messages sent from the same phone without any change of configuration will sometimes be recognised, sometimes not. Once recognised one message is recognised, the previous messages appear in the dedicated thread; however it doesn't mean that the next message will be recognised directly.

Comment 4

[Rick Waldron [:rwaldron]]

Are these in the body of the message?

Comment 5

[Victor]

No. There are the numbers I receive messages from.
So they are at the top of the screen, where the contact usually is.
Same problem in the notification. Sometimes the contact's name is written, sometimes it's just the number.

Comment 6

[Julien Wajsberg [:julienw]]

Victor: I believe your comment does not really belong to the same bug. This bug is about phone number recognition in the body of a message.
Your bug is unfortunately known on version 1.0.1 but the good news is that we fixed it for the next version 1.1 !

Comment 7

[Victor]

Sorry about that then. Thanks for the good news.
Now I have to find a way to update the firmware to 1.1 on the ZTE Open...

Comment 8

[Julien Wajsberg [:julienw]]

Victor: it's unfortunately not ready yet, I know we're working with them to have it quickly as an update but I don't have much more information.

Comment 9

[Julien Wajsberg [:julienw]]

still the question in comment 2.

And I think we'll WONTFIX this anyway.

Comment 10

[lecky]

hi,julien,

these phone numbers can be recognized on android phone.

So,the issue still WONTFIX anyway?

Comment 11

[Julien Wajsberg [:julienw]]

The problem I see with this is that it's not a real-world use case to me. But maybe it's easy to fix and in that case we should do it.

Let's investigate but I think this should not block the release. Joe, can we add this to the backlog ?

Comment 12

[Victor]

I experience this problem everyday on my ZTE phone.
It's a problem if people travel or use several sim cards/phones (cheaper, mostly seen in developping countries and near borders).
It would be great if it was solved, but it's not major so don't delay the release for that.

Although, and that's probably another bug but just to mention it, if you attribute two (or more) numbers to one person, the texts are not concatenated. It's number specific rather than person specific which, in my opinion, would be better.
Cheers,

Comment 13

[Julien Wajsberg [:julienw]]

Victor: the phone and url matching algorithms already greatly improved in v1.1 (see bug 870711 and bug 887737). But this specific bug is for edge cases.

Comment 14

[Julien Wajsberg [:julienw]]

Please file a bug for the second issue you have, with detailed STR (Steps To Reproduce) and I'll have a look, maybe it's already fixed in 1.1 too but here I can't say because I don't understand it ;-)

Comment 15

[Victor]

(In reply to Julien Wajsberg [:julienw] from comment #14)
> Please file a bug for the second issue you have, with detailed STR (Steps To
> Reproduce) and I'll have a look, maybe it's already fixed in 1.1 too but
> here I can't say because I don't understand it ;-)

https://bugzilla.mozilla.org/show_bug.cgi?id=911938

Comment 16

[lecky]

hi,julien,

do you mean that the issue may not be fixed on V1.1?

Comment 17

[Julien Wajsberg [:julienw]]

lecky> I really think this is not a blocker. Do you see this problem often in real life with current 1.1 code ? I think our current limited time is better used in other bugs.

Even if we have a patch, it would need to get a blocker flag like "leo+" for the v1.1 branch or "hd+" for the v1.1hd branch, and such blocker flags are usually not set for non-critical problems.

However feel free to investigate and even provide a patch, if the fix is simple and easy we may include it.

Comment 18

[Borja Salguero [:borjasalguero]]

I agree with Julien. This is not a blocker. Overall because the scenario that you describe it's more a feature than a bug, because my Android is making the same (it does not matter if I have '123' & '456' tied to a single contact, because messages received/sent to '123' and '456' are in different threads).

Comment 19

[Joe Cheng [:jcheng] (please needinfo)]

add to backlog bug 891754

Comment 20

[Wayne Chang [:wchang]]

This is not a blocker for v1.1 given its nature and that we will only take critical fixes now for v1.1/hd.

Anyone that thinks necessary can nom this koi? with rationale for triage.

Comment 21

[Julien Wajsberg [:julienw]]

We don't reconize these phone numbers because we have the "safe start" algorithm that does not include these characters. I don't know if we should do it, I don't exactly remember why we did this "safe start" algorithm and this would need some bug archeology.

I can keep this bug open though.

Comment 22

[Julien Wajsberg [:julienw]]

Mass closing of Gaia::SMS bugs. End of an era :(

Comment 23

[Julien Wajsberg [:julienw]]

Mass closing of Gaia::SMS bugs. End of an era :(