907586 - [B2G][Helix][Contacts][wangchao]It can't import contacts from SD card when Other device shared a vcf file via BT.

Status: RESOLVED WONTFIX

(Firefox OS Graveyard :: Gaia::Contacts, defect, P2)

Description

[wangchao]

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; Trident/4.0; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; .NET4.0C; .NET4.0E; Tablet PC 2.0)

Steps to reproduce:

1. Other device share a vcf file via BT to the test device.
2. The test device click import contact from SD card.


Actual results:

1. It Prompts "can't import contacts from SD card."


Expected results:

1. It can import contacts from SD card.

Comment 1

[wangchao]

I found the reason: the contacts can not read the format of vcf file received from other device. 

If i delete the vcf file(tx_vcard_can not import.vcf, in attachment), it can import from SD card again.

I think this is a Compatibility problem and we can't Stop user receiving vcf files from other device via BT. 

Thanks!

Comment 2

[wangchao]

Attachment: tx_vcard_can not import.vcf

Comment 3

[lecky]

Attachment: other vcf the ffos do not recognize

Comment 4

[lecky]

There are 2 points here:

1. If one of the vcf files can not be recognized, it can read left others. This is a "Fault Tolerance" issue.

2. Add feature to recognize the vcf file that received from other device. This is a "Compatibility" issue.

Thanks!

Comment 5

[lecky]

Attachment: contact_1000_English.vcf can not be recognized

Comment 6

[lecky]

There are many formats vcf can not be recognized.

Could you give me a list that now support?

So we can filter them and not test.

Thanks!

Comment 7

[lecky]

This will be fixed or supported in HD v1.1?

Thanks!

Comment 8

[Wayne Chang [:wchang]]

Hi Alberto, Jose,

Can you check if the attached vcf is a supported format or if there is a problem?

Thanks

Comment 9

[Preeti Raghunath(:Preeti)]

Ken,

Please check if this is a blue tooth issue.

Comment 10

[Ken Chang[:kenkai]]

The owner of BT is eric.

Comment 11

[Eric Chou [:ericchou] [:echou]]

I followed the STR, testing with the latest gaia:master/gecko:m-c. Contacts could be imported successfully.

Gecko: 148216:f97307cb4c95
Gaia : 37866768b8abda56d089c8fe96ec5298fc1df696

Please try again with the latest build (v1.2 should work as well) and see if the problem still exists.

Comment 12

[lecky]

Hi Eric:

   Are you using the attached VCF file:'tx_vcard_can not import.vcf' ?

   Another question: what is gecko:m-c? I do not know what m-c is stand for.

   Our version is Helix V1.1HD.

   Please change '[e-mail]' to me if you need my information.

Thanks!

Comment 13

[Eric Chou [:ericchou] [:echou]]

Hi lecky,

> 
>    Are you using the attached VCF file:'tx_vcard_can not import.vcf' ?
> 

The title of file I used was "other vcf the ffos do not recognize" (300 symbian-android-out.vcf).

>    Another question: what is gecko:m-c? I do not know what m-c is stand for.
> 
>    Our version is Helix V1.1HD.

m-c stands for Mozilla-Central, it's our codebase of Gecko.

So this should be an issue in v1.1 but doesn't exist in v1.2.

> 
>    Please change '[e-mail]' to me if you need my information.
> 

ok.

- Eric

Comment 14

[Eric Chou [:ericchou] [:echou]]

Remove koi? flag since it's not a v1.2 bug. We need more investigation to see if it's a leo+ bug. I'm on it.

Comment 15

[Eric Chou [:ericchou] [:echou]]

Hi lecky,

I used unagi-mozilla-b2g18-20130922041201-ril01.01.00.019.229.zip for test and here's what I've got:

1. The .vcf file could be received successfully, but couldn't be imported by tapping the notification.
2. After receiving the .vcf file, I navigated to Contacts->Settings->Import Contacts(SD Card), I could import those contacts without any warning dialogs.

(The file I used was "300 symbian-android-out.vcf". It's included in the .rar of the attachment "other vcf the ffos do not recognize".)

Point 1 was just as expected. In terms of v1.1, we don't support importing contacts by tapping the "the file has been received" notification in the notification center. Please see bug 887663 for more details.

Comment 16

[lecky]

Hi Eric:

   Just now, i have done a fully test, 

1) For attachments:
 
   "300 symbian-android-out.vcf","contact_1000_English.vcf" can be correctly imported.

   But "tx_vcard_can_not_import.vcf" and "300 symbian.vcf" can not be imported. 

   The four files are correctly tranfered by BT, I have check this with the source files. All the four files can be imported in android, i think this is still a support format issue.

2) If one of the vcf files can not be imported, then the import operation will fail. All vcf files will not be imported. My expected result is: it should import recognized vcf files although others are not supported.

Thanks!

Comment 17

[Eric Chou [:ericchou] [:echou]]

(In reply to lecky from comment #16)
> Hi Eric:
> 
>    Just now, i have done a fully test, 
> 
> 1) For attachments:
>  
>    "300 symbian-android-out.vcf","contact_1000_English.vcf" can be correctly
> imported.
> 
>    But "tx_vcard_can_not_import.vcf" and "300 symbian.vcf" can not be
> imported. 
> 
>    The four files are correctly tranfered by BT, I have check this with the
> source files. All the four files can be imported in android, i think this is
> still a support format issue.
> 
> 2) If one of the vcf files can not be imported, then the import operation
> will fail. All vcf files will not be imported. My expected result is: it
> should import recognized vcf files although others are not supported.
> 
> Thanks!

I've done another test and I think this is not Bluetooth bug. I pushed "300 symbian.vcf" into my FxOS device directly, then tried "import contacts from memory card" but failed. Also, the same file cannot be imported even in gecko:m-c/gaia:master.

Reset component to Gaia::Contacts and let experts do further investigation.

Reset the component to Gaia::Contacts.

Comment 18

[lecky]

Hi Alberto, Jose,

    Eric Says it is not a BT problem and Reset the component to Gaia::Contacts.
      
    Can you spare some time to it?

Thanks

Comment 19

[Jose Manuel Cantera]

handover to Fernando who will be available on Monday.

thanks

Comment 20

[lecky]

Hi Wayne:

  Can you assign a guy for this, Eric Says it is not a BT problem and Reset the component to Gaia::Contacts?

Thanks!

Comment 21

[Wayne Chang [:wchang]]

over to Fernando.

Lets check this on v1.2 with eric's test results in comment 17.

Lecky, we do not see this as a critical bug to be worked on for v1.1.

Comment 22

[lecky]

Hi beatriz:
Could you help to check wehther you can accept this bug on V1.1HD?

Comment 23

[Fernando Jiménez Moreno [:ferjm]]

You probably meant to ni? fcampo :)

Comment 24

[Fernando Campo (:fcampo)]

Yup, taking a look

Comment 25

[lecky]

Hi Fernando Campo:

1. This is a format issue. There are many vcf formats, contacts just can recoganize a part of them.

2. If there are 2 vcf files, one is OK, the other can not be read, the both of the two can not be read.
We expected that contacts to read the ok one and ignore the bad one.

Can you help to set flag needinfo to "Yup", i do not his address.

Until now, Yup did not give any reponse, i think because he did not know this bugreport.

Thanks!

Comment 26

[Fernando Campo (:fcampo)]

Hi lecky, sorry for the lack of updates, but as this one is not a blocker, koi+ and 1.3 features takes preference on the bug queue. I can only dedicate my free cycles to this one (and some others)

(In reply to lecky from comment #25)
> Hi Fernando Campo:
> 
> 1. This is a format issue. There are many vcf formats, contacts just can
> recoganize a part of them.
So far we support vcard v2.1 v3.0 v4.0, I would need to check the codification of your examples to know more details on the issue, but as I stated before, the priority of this bug is quite low at the moment. I can free it if you have anyone else interested of taking it, because I won't be putting too much time on it on the next couple of weeks.
> 
> 2. If there are 2 vcf files, one is OK, the other can not be read, the both
> of the two can not be read.
> We expected that contacts to read the ok one and ignore the bad one.
Yes, importer work on batches right now, we would need to change the behaviour, or at least open a discussion about it, as the batches importing was introduced to improve the performance, if I recall correctly.
ni? sergi mansilla for more info about this.

> Can you help to set flag needinfo to "Yup", i do not his address.
> 
> Until now, Yup did not give any reponse, i think because he did not know
> this bugreport.
Sorry, this seems to be a misunderstanding (my fault). Yup is just a colloquial expression, not a person. My apologies

> Thanks!

Comment 27

[Sergi Mansilla [:sergi] (Telenor) [PTO]]

Actually, the VCF importer should not fail if one of the files is not valid, I guess this should be investigated at some point. Soon we will introduce a rewrite of the VCF importer that streams imports, to avoid buffering given that it currently runs into trouble when importing many thousands of records.

Comment 28

[Beatriz Rodríguez [:brg]]

(In reply to lecky from comment #22)
> Hi beatriz:
> Could you help to check wehther you can accept this bug on V1.1HD?
Not a blocker in v1-train now. Investigations to improve behaviour in newer branches are welcome.