907629 - [Settings][STK] STK menu keeps coming back

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[:gerard-majax]

If the user kills the Settings app, STK might come back.

STR:
 0. Receive a call
 1. Hang up on it
 2. STK menu should popup to propose things like "send a message", etc (it does on Orange F SIM card)
 3. Kill the Settings app, like a user would do (via task switcher)

Actual result:
 STK comes back, at the same menu it was.

This is kind of very bothering.

Comment 1

[:gerard-majax]

Please note that you might have to reboot the phone as a precondition: for subsequent calls, the STK menu does not pop.

Comment 2

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Probably, when you close settings you tell the STK app "STK_RESULT_NO_RESPONSE_FROM_USER" so STK resends the message again until a valid response (for the app) is received

@see https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/icc.js#L53

Please, got some traces (with gaia ones enabled) to verify this.

Comment 3

[:gerard-majax]

(In reply to Fernando R. Sela (no CC, needinfo please) [:frsela] from comment #2)
> Probably, when you close settings you tell the STK app
> "STK_RESULT_NO_RESPONSE_FROM_USER" so STK resends the message again until a
> valid response (for the app) is received
> 
> @see
> https://github.com/mozilla-b2g/gaia/blob/master/apps/settings/js/icc.js#L53
> 
> Please, got some traces (with gaia ones enabled) to verify this.

I'll check with those asap. But as far as I can tell, the code sending this STK_RESULT_NO_RESPONSE_FROM_USER was correctly triggered

Comment 4

[:gerard-majax]

Attachment: stk.log

Here is the log. First occurrence of STK is triggered because did not took the call. All subsequents are after I killed the Settings app.

Comment 5

[:gerard-majax]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/11664

Pointer to Github pull-request

Comment 6

[:gerard-majax]

Comment on attachment 793461 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/11664

Turns out that while discussing about this bug, julien came with the suggestion of using window.onbeforeunload instead of window.onunload. When doing this, I can't reproduce anymore on Inari.

Comment 7

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Comment on attachment 793461 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/11664

cool, thanks

Comment 8

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Not sure if bug 898236 is the same as this one.

Comment 9

[:gerard-majax]

(In reply to Fernando R. Sela (no CC, needinfo please) [:frsela] from comment #8)
> Not sure if bug 898236 is the same as this one.

That might.

Comment 10

[Fernando R. Sela (no CC, needinfo please) [:frsela]]

Landed: https://github.com/mozilla-b2g/gaia/commit/04c122685311aa180d8b6284a9d4ced513782de6

Comment 11

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Shipped.