907648 - test_bug379959.html and test_bug369814.html should use SpecialPowers

Status: RESOLVED FIXED

(Core :: XBL, defect)

Description

[Martijn Wargers (dead)]

Attachment: 379959.diff

This test is still using old-style pref setting, the attached patch makes it so that it uses pushPrefEnv.

Comment 1

[Martijn Wargers (dead)]

Attachment: patch

docshell/test/test_bug369814.html is also still using old-style pref setting, I included that one as well in this patch.

Comment 2

[Martijn Wargers (dead)]

function startTests() in test_bug369814.html didn't seem to be used at all, so I just removed it.

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 793441 [details] [diff] [review]
patch

Review of attachment 793441 [details] [diff] [review]:
-----------------------------------------------------------------

thanks!  I assume these run great on all platforms, opt + debug.

::: docshell/test/test_bug369814.html
@@ +29,4 @@
>  var gCurrentTest;
>  var gTargetWindow;
>  var gNumPokes;
>  var gPrefValue;

we could probably remove this now?

Comment 4

[Martijn Wargers (dead)]

Yeah, gPrefValue can be removed, will do that in the patch that is ready to be checked in. In the meantime, pushed to try to test it on all platforms: https://tbpl.mozilla.org/?tree=Try&rev=4d4c5a1200b9

Comment 5

[Martijn Wargers (dead)]

Attachment: 907648.diff

This is what I pushed to try.

Comment 6

[Martijn Wargers (dead)]

Attachment: 907648.diff (for check-in)

Try is green, this is for check-in.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/4e2ac1af3047

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/4e2ac1af3047