907649 - Color wheel - Hexadecimal input doesn't work

Status: VERIFIED FIXED

(Webmaker Graveyard :: Popcorn Maker, defect)

Description

[melissa]

Color wheel doesn't save hexadecimal written in; must find color on the wheel for it to register. 

Steps (same for font and shadow colors):
1. Wrote something in a text box.
2. Changed font color using color wheel.
3. Created new text box, wrote something different.
4. Copied hexadecimal of first color; pasted in hex box of second text box (to have same font colors). => color wheel shifts to show correct color.
5. Hit enter.
6. Clicked elsewhere on Popcorn Maker; clicked back on second text box to see if color had changed to desired hex => hex was back to the initial color (no font change).

Comment 1

[Laura Hilliger [:epilepticrabbit]]

Confirming this! Was about to file a new bug and ended up finding Melissa's report - someone want to comment?

Comment 2

[Jon Buckley [:jbuck]]

Scott, can you take a look at this?

Comment 3

[Scott [:thecount] Downe]

Attachment: https://github.com/mozilla/popcorn.webmaker.org/pull/224

Ooops, that totally existed while I was developing, but at some point during review and or final changes, it was removed.

I also added a click event to focus when clicked on the colour box. That was also intended but got lost for probably similar reasons.

Comment 4

[Matthew Schranz [:mjschranz]]

Comment on attachment 809202 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/224

If I send invalid input, I get an error message as expected.

However, the colour toggle looses it's colour and is transparent. I'm thinking we should revert to the last valid value.

Comment 5

[Scott [:thecount] Downe]

Comment on attachment 809202 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/224

Fixed up.

Also made named colours like "blue" and "green" change the colour picker too.

Comment 6

[Scott [:thecount] Downe]

Staged: https://github.com/mozilla/popcorn.webmaker.org/commit/0fd32a960213567508879ff941cb3a92d9acde80

Need verification.