Color wheel - Hexadecimal input doesn't work

VERIFIED FIXED

Status

Webmaker
Popcorn Maker
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: melissa, Assigned: thecount)

Tracking

Details

(Whiteboard: [mentor])

Attachments

(1 attachment)

(Reporter)

Description

4 years ago
Color wheel doesn't save hexadecimal written in; must find color on the wheel for it to register. 

Steps (same for font and shadow colors):
1. Wrote something in a text box.
2. Changed font color using color wheel.
3. Created new text box, wrote something different.
4. Copied hexadecimal of first color; pasted in hex box of second text box (to have same font colors). => color wheel shifts to show correct color.
5. Hit enter.
6. Clicked elsewhere on Popcorn Maker; clicked back on second text box to see if color had changed to desired hex => hex was back to the initial color (no font change).
Confirming this! Was about to file a new bug and ended up finding Melissa's report - someone want to comment?
Whiteboard: [mentor]

Comment 2

4 years ago
Scott, can you take a look at this?
Assignee: nobody → scott
(Assignee)

Comment 3

4 years ago
Created attachment 809202 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/224

Ooops, that totally existed while I was developing, but at some point during review and or final changes, it was removed.

I also added a click event to focus when clicked on the colour box. That was also intended but got lost for probably similar reasons.
Attachment #809202 - Flags: review?(schranz.m)
Comment on attachment 809202 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/224

If I send invalid input, I get an error message as expected.

However, the colour toggle looses it's colour and is transparent. I'm thinking we should revert to the last valid value.
Attachment #809202 - Flags: review?(schranz.m) → review-
(Assignee)

Comment 5

4 years ago
Comment on attachment 809202 [details] [review]
https://github.com/mozilla/popcorn.webmaker.org/pull/224

Fixed up.

Also made named colours like "blue" and "green" change the colour picker too.
Attachment #809202 - Flags: review- → review?(schranz.m)
Attachment #809202 - Flags: review?(schranz.m) → review+
(Assignee)

Comment 6

4 years ago
Staged: https://github.com/mozilla/popcorn.webmaker.org/commit/0fd32a960213567508879ff941cb3a92d9acde80

Need verification.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Flags: needinfo?(scott)
Resolution: --- → FIXED
(Assignee)

Updated

4 years ago
Status: RESOLVED → VERIFIED
Flags: needinfo?(scott)
Attachment mime type: text/plain → text/x-github-pull-request
You need to log in before you can comment on or make changes to this bug.