907660 - Add log for user deactivations

Status: VERIFIED FIXED

(support.mozilla.org :: Knowledge Base Software, task, P4)

Description

[Kadir Topal [:atopal]]

User Story: As a forum moderator I want to know when and by whom an account is being deactivated so I can check whether I agree with a decision.

UX: Please add a page that logs user deactivations with the following columns:

user who was deactivated, moderator who deactivated, time of deactivation

Please link to this log from https://support.mozilla.org/en-US/flagged

Comment 1

[Ricky Rosario [:rrosario, :r1cky]]

I think we should hold off on this until we are on Persona and decide what we should be doing with deactivated accounts in that case. Does it basically blacklist the email address from signing in ever again?

Currently we use the is_active flag for two things:
* Users that haven't verified their email (this goes away with Persona)
* Users we don't want to be able to log in again because of whatever reason

Comment 2

[Kadir Topal [:atopal]]

We are also using it to let moderators stop spammers, before an admin can react and remove the account.

What does deactivating do today? Keep them from signing in ever again?

Comment 3

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Kadir Topal [:atopal] from comment #2)
> What does deactivating do today? Keep them from signing in ever again?

Yeah, basically it blocks them from signing in.

Comment 4

[John Hesling [:John99] (NeedInfo me)]

Would I be correct in saying it currently prevents a deactivated user signing in to AAQ & other fora, but it does not prevent a user signing in to the profile. A deactivated user is still able to send Private Messages.I believe that is desirable as it allows an appeal.

Oddly sumo apparently has no open general contact email address.

Comment 5

[Kadir Topal [:atopal]]

Ricky, how is this blocked by Persona? This would just be a log of the action. Whatever the action would entail is not part of this bug. Maybe I'm missing something?

Comment 6

[Ricky Rosario [:rrosario, :r1cky]]

(In reply to Kadir Topal [:atopal] from comment #5)
> Ricky, how is this blocked by Persona? This would just be a log of the
> action. Whatever the action would entail is not part of this bug. Maybe I'm
> missing something?

It isn't exactly blocked. We just need to decide what to do when a user is deactivated and they try to sign in with Persona. My guess is they just won't be able to sign in. I don't know if it is currently implemented like that though. We could test it on stage.

Comment 7

[Ricky Rosario [:rrosario, :r1cky]]

We are focusing on Open Badges and Persona in 2013.18

Comment 8

[Kadir Topal [:atopal]]

When the account is deactivated you can still log in to Persona, but you can't use the log-in on SUMO anymore: bug 914578

Comment 9

[Kadir Topal [:atopal]]

Pushing to next sprint, since we are focusing on Q3 goals in this short sprint.

Comment 10

[Ricky Rosario [:rrosario, :r1cky]]

Q3 is over... => Q4

Comment 11

[Ricky Rosario [:rrosario, :r1cky]]

pushing to next sprint.

Comment 12

[Ricky Rosario [:rrosario, :r1cky]]

We need to create a new model that stores: user who was deactivated, moderator who deactivated, time of deactivation

We need to create a new view + template that lists all the instances and paginates them.

Comment 13

[Ricky Rosario [:rrosario, :r1cky]]

Missed. Pushing to next sprint.

Comment 14

[Ricky Rosario [:rrosario, :r1cky]]

Moving along during sprint planning.

Comment 15

[Kadir Topal [:atopal]]

Hey Ricky, can we extend this to include post and thread deletions? If not, let's move that to bug 939938

Comment 16

[Ricky Rosario [:rrosario, :r1cky]]

Deployed to prod:
https://github.com/mozilla/kitsune/commit/e99e0d1456190a8866aefe416f449843b386debb

PR was here:
https://github.com/mozilla/kitsune/pull/1733

Comment 17

[[:philipp]]

would it be possible in the deactivation log to link the nickname of the deactivated user to his/her profile?

Comment 18

[Will Kahn-Greene [:willkg] ET needinfo? me]

(In reply to philipp from comment #17)
> would it be possible in the deactivation log to link the nickname of the
> deactivated user to his/her profile?

That and any other tweaks to the log should be in a new bug.

Comment 19

[Andrew Truong [:feer56] [:andrewtruong] [:atruong]]

(In reply to philipp from comment #17)
> would it be possible in the deactivation log to link the nickname of the
> deactivated user to his/her profile?

philipp - feel free to file a new bug for that.

Comment 20

[[:philipp]]

thanks, did so in bug 944344