Closed
Bug 907683
Opened 11 years ago
Closed 9 months ago
Cleanup ipc/chromium/chromium-config.mk
Categories
(Firefox Build System :: General, defect)
Tracking
(Not tracked)
RESOLVED
DUPLICATE
of bug 1835185
People
(Reporter: glandium, Assigned: glandium)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
2.81 KB,
patch
|
benjamin
:
review+
gaston
:
feedback+
|
Details | Diff | Splinter Review |
The ipc/chromium/src/build/build_config.h file does most of what chromium-config.mk does, which makes the maintenance burden higher than it should be.
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #793455 -
Flags: review?(benjamin)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Comment on attachment 793455 [details] [diff] [review] Cleanup ipc/chromium/chromium-config.mk Landry, can you double-check this doesn't break openbsd? (which it's not supposed to)
Attachment #793455 -
Flags: feedback?(landry)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 793455 [details] [diff] [review] Cleanup ipc/chromium/chromium-config.mk No fallout for me on OpenBSD
Attachment #793455 -
Flags: feedback?(landry) → feedback+
|
||
Updated•11 years ago
|
Attachment #793455 -
Flags: review?(benjamin) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/9c78c5ac85a8
|
|
Assignee | |
Comment 5•11 years ago
|
||
Backed out https://hg.mozilla.org/integration/mozilla-inbound/rev/bb7959840ea5
|
|
Assignee | |
Comment 6•11 years ago
|
||
And the failure comes from bug 901583, which changed some include paths and made ./media/webrtc/trunk/build/build_config.h be used in some cases instead of ./ipc/chromium/src/build/build_config.h, and both don't define the same things...
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
|
|
||
Updated•2 years ago
|
Severity: normal → S3
|
|
Assignee | |
Comment 7•9 months ago
|
||
This was largely addressed in bug 1835185.
You need to log in
before you can comment on or make changes to this bug.
Description
•