Open Bug 907683 Opened 6 years ago Updated 2 years ago

Cleanup ipc/chromium/chromium-config.mk

Categories

(Firefox Build System :: General, defect)

x86_64
Linux
defect
Not set

Tracking

(Not tracked)

People

(Reporter: glandium, Assigned: glandium)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

The ipc/chromium/src/build/build_config.h file does most of what chromium-config.mk does, which makes the maintenance burden higher than it should be.
Comment on attachment 793455 [details] [diff] [review]
Cleanup ipc/chromium/chromium-config.mk

Landry, can you double-check this doesn't break openbsd? (which it's not supposed to)
Attachment #793455 - Flags: feedback?(landry)
Comment on attachment 793455 [details] [diff] [review]
Cleanup ipc/chromium/chromium-config.mk

No fallout for me on OpenBSD
Attachment #793455 - Flags: feedback?(landry) → feedback+
Attachment #793455 - Flags: review?(benjamin) → review+
And the failure comes from bug 901583, which changed some include paths and made ./media/webrtc/trunk/build/build_config.h be used in some cases instead of ./ipc/chromium/src/build/build_config.h, and both don't define the same things...
Blocks: 883502
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.