Closed Bug 907692 Opened 8 years ago Closed 8 years ago
[Contacts] transforming to vcard should provide a blob
Use the recent created component to transform mozContact to vcard to generate a file with that correct format.
blocking-b2g: --- → koi?
Whiteboard: [u=commsapps-user c=contacts p=0]
Summary: [Contacts] Create a vcard file → [Contacts] transforming to vcard should provide a blob file
Assignee: nobody → francisco.jordano
Summary: [Contacts] transforming to vcard should provide a blob file → [Contacts] transforming to vcard should provide a blob
Comment on attachment 794661 [details] Pointer to PR 11722 I think this will work, but I made a style/design comment on the PR. I think it might be a bit cleaner to create a ContactToVcardBlob() function vs. appending a boolean argument to the current function. In either case, however, I think this looks functionally correct and has a unit test, so r+. Thanks Francisco!
Attachment #794661 - Flags: review?(bkelly) → review+
I added the suggestion, tests are passing locally, and in travis are failing some tests not related to this PR. I'll merge this change, thanks!
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Whiteboard: [u=commsapps-user c=contacts p=0] → [u=commsapps-user c=contacts p=1]
koi+ this is needed for v1.2 stories
blocking-b2g: koi? → koi+
You need to log in before you can comment on or make changes to this bug.