Closed Bug 907692 Opened 10 years ago Closed 10 years ago

[Contacts] transforming to vcard should provide a blob

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Contacts
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:koi+)

Status:
RESOLVED FIXED
Project Flags:
blocking-b2g koi+

People

(Reporter: arcturus, Assigned: arcturus)

References

Details

(Whiteboard: [u=commsapps-user c=contacts p=1])

Attachments

(1 file)

Pointer to PR 11722
359 bytes, text/html
bkelly
: review+
Details 
Use the recent created component to transform mozContact to vcard to generate a file with that correct format.
blocking-b2g: --- → koi?
Whiteboard: [u=commsapps-user c=contacts p=0]
Summary: [Contacts] Create a vcard file → [Contacts] transforming to vcard should provide a blob file
Assignee: nobody → francisco.jordano
Summary: [Contacts] transforming to vcard should provide a blob file → [Contacts] transforming to vcard should provide a blob
Attached file Pointer to PR 11722 — 

        Attachment #794661 -
        Flags: review?(sergi.mansilla)

        Attachment #794661 -
        Flags: review?(bkelly)
Status: NEW → ASSIGNED

    
    

    
  
Comment on attachment 794661 [details]
Pointer to PR 11722

I think this will work, but I made a style/design comment on the PR.  I think it might be a bit cleaner to create a ContactToVcardBlob() function vs. appending a boolean argument to the current function.

In either case, however, I think this looks functionally correct and has a unit test, so r+.

Thanks Francisco!

        Attachment #794661 -
        Flags: review?(bkelly) → review+

    
    

    
  
I added the suggestion, tests are passing locally, and in travis are failing some tests not related to this PR.

I'll merge this change, thanks!

    
    

    
  
Landed:

https://github.com/mozilla-b2g/gaia/commit/3b3edd422e5fb6ebc14c5458f710ceb9ae0ca712
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [u=commsapps-user c=contacts p=0] → [u=commsapps-user c=contacts p=1]

    
    

    
  
koi+ this is needed for v1.2 stories
blocking-b2g: koi? → koi+

        Attachment #794661 -
        Flags: review?(sergi.mansilla)

          You need to log in
          before you can comment on or make changes to this bug.