Closed
Bug 907692
Opened 11 years ago
Closed 11 years ago
[Contacts] transforming to vcard should provide a blob
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(blocking-b2g:koi+)
RESOLVED
FIXED
| blocking-b2g | koi+ |
People
(Reporter: arcturus, Assigned: arcturus)
References
Details
(Whiteboard: [u=commsapps-user c=contacts p=1])
Attachments
(1 file)
Use the recent created component to transform mozContact to vcard to generate a file with that correct format.
|
Assignee | |
Updated•11 years ago
|
blocking-b2g: --- → koi?
Whiteboard: [u=commsapps-user c=contacts p=0]
|
|
Assignee | |
Updated•11 years ago
|
Summary: [Contacts] Create a vcard file → [Contacts] transforming to vcard should provide a blob file
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → francisco.jordano
|
|
Assignee | |
Updated•11 years ago
|
Summary: [Contacts] transforming to vcard should provide a blob file → [Contacts] transforming to vcard should provide a blob
|
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #794661 -
Flags: review?(sergi.mansilla)
Attachment #794661 -
Flags: review?(bkelly)
|
|
Assignee | |
Updated•11 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 2•11 years ago
|
||
Comment on attachment 794661 [details]
Pointer to PR 11722
I think this will work, but I made a style/design comment on the PR. I think it might be a bit cleaner to create a ContactToVcardBlob() function vs. appending a boolean argument to the current function.
In either case, however, I think this looks functionally correct and has a unit test, so r+.
Thanks Francisco!
Attachment #794661 -
Flags: review?(bkelly) → review+
|
|
Assignee | |
Comment 3•11 years ago
|
||
I added the suggestion, tests are passing locally, and in travis are failing some tests not related to this PR. I'll merge this change, thanks!
|
|
Assignee | |
Comment 4•11 years ago
|
||
Landed: https://github.com/mozilla-b2g/gaia/commit/3b3edd422e5fb6ebc14c5458f710ceb9ae0ca712
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [u=commsapps-user c=contacts p=0] → [u=commsapps-user c=contacts p=1]
|
||
Updated•10 years ago
|
Attachment #794661 -
Flags: review?(sergi.mansilla)
You need to log in
before you can comment on or make changes to this bug.
Description
•