907700 - [HD][Usage] Update subtext

Status: VERIFIED FIXED

(Firefox OS Graveyard :: Gaia::Cost Control, defect, P3)

Description

[Eric Pang [:epang] UX]

Attachment: Usage.png

Pavel, can you update the styling of the subtext on the following screens?  They should use the same styling as settings (see the right most screen)

Data Alert
'Set an alert to avoid using too much data.'

Data Report
'Receive reports about your internet usage.'

I've also highlighted layout issues
ex, 15px margins, full length drop downs and buttons, 30px margin for text. Will these be taken care of by other bugs?

Thanks!

Comment 1

[Wayne Chang [:wchang]]

HD+ layout

Comment 2

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

I think we can't do this for 24.08 :(

Comment 3

[Eric Pang [:epang] UX]

Hey Pavel, have you had a chance to look into updated the subtext for this bug?  I believe the other elements will be updated when other bugs land, but let me know if I'm mistaken. thanks!

Comment 4

[Wayne Chang [:wchang]]

Where are we with this?

Comment 5

[Pavel Ivanov [:ivanovpavel][:pivanov] UX]

Hey guys,
I still don't have a HD device ... and it's hard to test only on desktop ...

Comment 6

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: before_and_after.png

Hey Patryk, I have not found visuals for that screens, but I've tweaked a bit the layout to get the right margins as in Settings app.

Comment 7

[Arnau March [:arnau] ( not working in Firefox OS anymore :( )]

Attachment: patch in github

Comment 8

[Salvador de la Puente González [:salva]]

Comment on attachment 8407193 [details] [review]
patch in github

Passing to José Manuel who is reviewing other style changes as well.

Comment 9

[Jose Manuel Cantera]

Comment on attachment 8407193 [details] [review]
patch in github

thanks Arnau

I think we need another round to solve the issues described on GH.

Comment 10

[Paco Rampas [:paco]]

Attachment: patch in github

Comment 11

[Marina Rodríguez [:mai]]

Comment on attachment 8470707 [details] [review]
patch in github

Please, address the comments on GitHub and ask for my review again.
Thanks!

Comment 12

[Marina Rodríguez [:mai]]

Comment on attachment 8470707 [details] [review]
patch in github

Looks good to me, r+
Thanks

Comment 13

[Paco Rampas [:paco]]

landed: 9c749ddc14bae186fa3ddc98e16659f122a1c1ee

Comment 14

[Marina Rodríguez [:mai]]

Comment on attachment 8470707 [details] [review]
patch in github

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Visual polish
[User impact] if declined: The app style will not be aligned with the rest of applications
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): Low risk
[String changes made]:No

This patch is part of the visual refresh started on 2.0.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

Needs rebasing for v2.1 uplift.

Comment 16

[Paco Rampas [:paco]]

Attachment: patch v2.1 in github

Comment 17

[Marina Rodríguez [:mai]]

Comment on attachment 8493029 [details] [review]
patch v2.1 in github

Works fine, thanks

Comment 18

[Ryan VanderMeulen [:RyanVM]]

v2.1: https://github.com/mozilla-b2g/gaia/commit/05f7d41f53339f9b007d6fec8b7dc81a87339561

Comment 19

[Sue]

Attachment: screenshot

This issue has been verified successfully on Flame v2.1 & v2.2
See attachment: screenshot.PNG
Reproducing rate: 0/5
Flame 2.1 versions:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141130001203
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141130.034738
FW-Date         Sun Nov 30 03:47:49 EST 2014
Bootloader      L1TC00011880

Flame 2.0 versions:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141130000204
Version         32.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141130.032432
FW-Date         Sun Nov 30 03:24:44 EST 2014
Bootloader      L1TC00011880