Closed Bug 907700 Opened 11 years ago Closed 10 years ago

[HD][Usage] Update subtext

Categories

(Firefox OS Graveyard :: Gaia::Cost Control, defect, P3)

Product:
Firefox OS Graveyard
Component:
Gaia::Cost Control
Platform:
All
Other
Type:
defect

Tracking

(b2g-v2.1 verified, b2g-v2.2 verified)

Status:
VERIFIED FIXED
Milestone:
2.1 S4 (12sep)
Tracking Flags:
Tracking Status
b2g-v2.1 --- verified
b2g-v2.2 --- verified

People

(Reporter: epang, Assigned: paco)

References

Details

(Whiteboard: helix vsd, HD)

Attachments

(5 files, 1 obsolete file)

Usage.png
150.68 KB, image/png
Details
before_and_after.png
72.98 KB, image/png
padamczyk
: ui-review+
Details
patch in github
46 bytes, text/x-github-pull-request
mai
: review+
fabrice
: approval-gaia-v2.1+
Details | Review
patch v2.1 in github
46 bytes, text/x-github-pull-request
mai
: review+
Details | Review
screenshot
101.31 KB, image/png
Details
Attached image Usage.png — 
Pavel, can you update the styling of the subtext on the following screens?  They should use the same styling as settings (see the right most screen)

Data Alert
'Set an alert to avoid using too much data.'

Data Report
'Receive reports about your internet usage.'

I've also highlighted layout issues
ex, 15px margins, full length drop downs and buttons, 30px margin for text. Will these be taken care of by other bugs?

Thanks!
Whiteboard: helix vsd → helix vsd, HD
HD+ layout
blocking-b2g: hd? → hd+
I think we can't do this for 24.08 :(
Hey Pavel, have you had a chance to look into updated the subtext for this bug?  I believe the other elements will be updated when other bugs land, but let me know if I'm mistaken. thanks!
Flags: needinfo?(pivanov)
Where are we with this?
Hey guys,
I still don't have a HD device ... and it's hard to test only on desktop ...
Flags: needinfo?(pivanov)
blocking-b2g: hd+ → ---
Blocks: 992160
Attached image before_and_after.png — 
Hey Patryk, I have not found visuals for that screens, but I've tweaked a bit the layout to get the right margins as in Settings app.
Attachment #8407191 - Flags: ui-review?(padamczyk)
Comment on attachment 8407193 [details] [review]
patch in github

Passing to José Manuel who is reviewing other style changes as well.
Attachment #8407193 - Flags: review?(salva) → review?(jmcf)
Assignee: pivanov → arnau
Attachment #8407191 - Flags: ui-review?(padamczyk) → ui-review+
Comment on attachment 8407193 [details] [review]
patch in github

thanks Arnau

I think we need another round to solve the issues described on GH.
Attachment #8407193 - Flags: review?(jmcf)
Assignee: rnowmrch → pacorampas
Attached file patch in github — 

        Attachment #8470707 -
        Flags: review?(mri)

    
  

        Attachment #8407193 -
        Attachment is obsolete: true

        Attachment #8470707 -
        Flags: review?(mri)

    
  

        Attachment #8470707 -
        Flags: review?(mri)

    
    

    
  
Comment on attachment 8470707 [details] [review]
patch in github

Please, address the comments on GitHub and ask for my review again.
Thanks!

        Attachment #8470707 -
        Flags: review?(mri)

    
  

        Attachment #8470707 -
        Flags: review?(mri)

    
    

    
  
Comment on attachment 8470707 [details] [review]
patch in github

Looks good to me, r+
Thanks

        Attachment #8470707 -
        Flags: review?(mri) → review+

    
    

    
  
landed: 9c749ddc14bae186fa3ddc98e16659f122a1c1ee
Status: NEW → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED

          status-b2g-v2.2:
          --- → fixed
Target Milestone: --- → 2.1 S4 (12sep)

    
    

    
  
Comment on attachment 8470707 [details] [review]
patch in github

[Approval Request Comment]
[Bug caused by] (feature/regressing bug #): Visual polish
[User impact] if declined: The app style will not be aligned with the rest of applications
[Testing completed]: Yes
[Risk to taking this patch] (and alternatives if risky): Low risk
[String changes made]:No

This patch is part of the visual refresh started on 2.0.

        Attachment #8470707 -
        Flags: approval-gaia-v2.1?(release-mgmt)

        Attachment #8470707 -
        Flags: approval-gaia-v2.1?(release-mgmt) → approval-gaia-v2.1+

    
    

    
  
Needs rebasing for v2.1 uplift.
Flags: needinfo?(pacorampas)
Keywords: branch-patch-needed

    
    

    
  

      
      
      
      

        Attached file
          
        patch v2.1 in github
        — 
      

    


  

        Attachment #8493029 -
        Flags: review?(mri)
Flags: needinfo?(pacorampas)

    
    

    
  
Comment on attachment 8493029 [details] [review]
patch v2.1 in github

Works fine, thanks

        Attachment #8493029 -
        Flags: review?(mri) → review+

    
    

    
  

      
      
      
      

        Attached image
          
        screenshot
        — 
      

    


  
This issue has been verified successfully on Flame v2.1 & v2.2
See attachment: screenshot.PNG
Reproducing rate: 0/5
Flame 2.1 versions:
Gaia-Rev        ccb49abe412c978a4045f0c75abff534372716c4
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g34_v2_1/rev/18fb67530b22
Build-ID        20141130001203
Version         34.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141130.034738
FW-Date         Sun Nov 30 03:47:49 EST 2014
Bootloader      L1TC00011880

Flame 2.0 versions:
Gaia-Rev        8d1e868864c8a8f1e037685f0656d1da70d08c06
Gecko-Rev       https://hg.mozilla.org/releases/mozilla-b2g32_v2_0/rev/c756bd8bf3c3
Build-ID        20141130000204
Version         32.0
Device-Name     flame
FW-Release      4.4.2
FW-Incremental  eng.cltbld.20141130.032432
FW-Date         Sun Nov 30 03:24:44 EST 2014
Bootloader      L1TC00011880

    
  
Status: RESOLVED → VERIFIED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: