Closed Bug 907728 Opened 6 years ago Closed 6 years ago

use function overloading instead of defaulted arguments for nsTSubstring::Assign

Categories

(Core :: XPCOM, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: froydnj, Unassigned)

Details

Attachments

(1 file)

No description provided.
Loading -1 at all call sites can be surprisingly expensive.  Moving the loading into
the callee saves a little over 1K of code space on a Android build.  Not a lot, but
I will take codesize improvements wherever I can get them...WDYT?
Attachment #793486 - Flags: review?(justin.lebar+bug)
Comment on attachment 793486 [details] [diff] [review]
use function overloading instead of defaulted arguments for nsTSubstring::Assign

SGTM!
Attachment #793486 - Flags: review?(justin.lebar+bug) → review+
https://hg.mozilla.org/mozilla-central/rev/5ab49dfc686b
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.