Closed
Bug 907757
Opened 11 years ago
Closed 11 years ago
[Contacts][Activity] When running activity 'pick' from SMS, badly worded dialogue informing that message cannot be sent to contact with no phone number.
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect)
Tracking
(blocking-b2g:koi+)
RESOLVED
FIXED
blocking-b2g | koi+ |
People
(Reporter: maat, Assigned: gerard-majax)
Details
(Whiteboard: [u=commsapps-user c=contacts p=0])
Attachments
(2 files)
badly worded dialogue informing user that message cannot be sent to contact we need to address this bug until bug 907752 is implemented **PATH 1** 1) prerequisite: contact list must contain unlinked Facebook contacts and local contacts without a phone number associated to them 2) open messages app 3) select the plus icon to launch the contact list 4) select a contact (Facebook or local) that does not have a phone number associated to it **EXPECTED** Layer appears clearly informing user that messages cannot be sent to the selected contact **ACTUAL** Layer appears that says "No phones".. this message is also poorly worded and as long as it is there we need better wording. Ni? to Tyler to provide better copy for this layer.
Reporter | ||
Updated•11 years ago
|
blocking-b2g: --- → koi?
Flags: needinfo?(tyler.altes)
Comment 1•11 years ago
|
||
Is there a way to see a screenshot of this for visual context?
Reporter | ||
Comment 2•11 years ago
|
||
(In reply to tyler.altes from comment #1) > Is there a way to see a screenshot of this for visual context? Sure, will attach one in a couple of hours. Please needinfo me tyler if you want me to respond... email is f.u.l.l... :)
Comment 4•11 years ago
|
||
Perfect, I would leave the message like this: There is no phone number related to this contact.
Flags: needinfo?(tyler.altes)
Comment 6•11 years ago
|
||
This is quite bad but the conclusion of the discussion in triage today was that this doesn't meet blocker criteria (https://wiki.mozilla.org/B2G/Triage#Issues_that_Should_Block). I'm moving back to koi? but I doubt whether it would block that either and is just something we should fix for 1.2.
blocking-b2g: leo? → koi?
Updated•11 years ago
|
Component: Gaia::SMS → Gaia::Contacts
Updated•11 years ago
|
blocking-b2g: koi? → koi+
Updated•11 years ago
|
Whiteboard: [u=commsapps-user c=contacts p=0]
Updated•11 years ago
|
Summary: [messages] badly worded dialogue informing user that message cannot be sent to contact → [Contacts][Activity] When running activity 'pick' from SMS, badly worded dialogue informing that message cannot be sent to contact with no phone number.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → lissyx+mozillians
Assignee | ||
Comment 7•11 years ago
|
||
Looking at the code and the locales, I'd say it's also the case for the "no_email" case. But to me this just looks l10n/UX ?
Assignee | ||
Comment 8•11 years ago
|
||
Pointer to Github pull-request
Assignee | ||
Comment 9•11 years ago
|
||
Comment on attachment 801488 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12028 Please find attached a link to the github pull request that addresses this issue.
Attachment #801488 -
Flags: review?(francisco.jordano)
Comment 10•11 years ago
|
||
Comment on attachment 801488 [details] Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12028 Nice one, simple patch, working on the phone perfectly.
Attachment #801488 -
Flags: review?(francisco.jordano) → review+
Comment 11•11 years ago
|
||
Landed: https://github.com/mozilla-b2g/gaia/commit/aa4180e9286d385fa6b62d236f30fb24cd8b93e9 \o/ Thanks Alexandre
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•