56 bytes, text/x-github-pull-request
|Details | Review|
Right now we only have a quick fix for overriding the path for all the templates files.
Hi, Interesting bug. If no one is working on this. Assign this one to me. Thanks, Zak
You can flag Matthew Schranz [:mjschranz] for review after you have complete this bug. Thanks @Zakeria.
Assignee: nobody → zak.hassan1010
More context of this bug. See https://github.com/mozilla/popcorn.webmaker.org/blob/master/server.js#L243-L266 we want to be able to route to all these but without having to write 20+ lines of code in the server.js This is how we have done it for Thimble https://github.com/mozilla/thimble.webmaker.org/blob/master/routes/index.js#L54-L92 https://github.com/mozilla/thimble.webmaker.org/blob/master/app.js#L271 It'd be great to have it better than Thimble if you can find a way else the same with Thimble should be acceptable (Preferable something better :P ).
Move the files into the views directory?
Assigning this to myself for now.
Assignee: zak.hassan1010 → ali
Comment on attachment 8397372 [details] [review] https://github.com/mozilla/popcorn.webmaker.org/pull/525 I added a comment with how you can reduce this, by changing up the directory structure to something easier. If it doesn't make sense, feel free to ask questions. You can decide to go this way or not, really, what you have is fine too :)
Attachment #8397372 - Flags: review?(scott) → review-
Attachment #8397372 - Flags: review- → review?(scott)
Comment on attachment 8397372 [details] [review] https://github.com/mozilla/popcorn.webmaker.org/pull/525 Yeah, looks much better.
Attachment #8397372 - Flags: review?(scott) → review+
Commit pushed to master at https://github.com/mozilla/popcorn.webmaker.org https://github.com/mozilla/popcorn.webmaker.org/commit/b5870cb6d846b4806718155e760889dc7113720a bug907766 - Solution to route override
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.