907781 - remove inline style and script

Status: RESOLVED WONTFIX

(Webmaker Graveyard :: Thimble, defect)

Description

[Pomax]

we have several places where we have inline script and inline styles (i.e. not loaded from .js or .css files) in our pages, and we should really try to refactor this so that this isn't the case anywhere anymore.

This ticket can act as a meta ticket while we do an inventory of locations that need fixing, blocked on individual refactors.

Comment 1

[Zakeria Hassan]

If no one is working on this then can you assign this to me.

Comment 2

[David Humphrey (:humph)]

Sure.  Please start by doing an audit to find all instances of this, and report back in the bug for follow-up with Pomax on how to fix.  Thanks.

Comment 3

[Zakeria Hassan]

> The following files use inline css: using this command 'git grep 'style="'|awk '{print $1}'|uniq'

learning_projects/o2_thepitch.html
learning_projects/portfoliomaker.html
public/friendlycode/test/test-live-preview.js
public/friendlycode/vendor/codemirror3/mode/htmlmixed/index.html
public/friendlycode/vendor/codemirror3/mode/xml/index.html
public/friendlycode/vendor/slowparse/spec/index.html
public/friendlycode/vendor/slowparse/vendor/codemirror2/lib/codemirror.js
public/learning_projects/bunnies/source.svg
views/friendlycode/templates/confirm-dialog.html
views/friendlycode/templates/error-dialog.html
views/friendlycode/templates/publish-dialog.html
views/layout.html


For inline javascript: Used this command "git grep 'javascript:'|awk '{print $1}'" 

public/friendlycode/vendor/slowparse/test/test-tree-inspectors.js
public/learning_projects/s2r/style.css

Note: public/learning_projects/s2r/style.css: searches for inline javascript and sets some css on it.

Comment 4

[David Humphrey (:humph)]

I'll close this and we'll fix when we deal with CSP warnings in Bramble.