Closed
Bug 907796
Opened 11 years ago
Closed 11 years ago
Add error reporters to the Task.spawns within browser/components/customizableui
Categories
(Firefox :: Toolbars and Customization, defect)
Firefox
Toolbars and Customization
Tracking
()
RESOLVED
FIXED
Firefox 28
People
(Reporter: jaws, Assigned: jaws)
References
(Blocks 1 open bug)
Details
(Whiteboard: [Australis:M8])
Attachments
(2 files)
6.66 KB,
patch
|
Gijs
:
review+
|
Details | Diff | Splinter Review |
1.64 KB,
patch
|
MattN
:
review+
|
Details | Diff | Splinter Review |
We need to add error handlers inside of the Task.spawns within CustomizeMode.jsm (and possibly elsewhere within the customization code).
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #793617 -
Flags: review?(gijskruitbosch+bugs)
Assignee | ||
Updated•11 years ago
|
Summary: Add error reporters to the Task.spawns within CustomizeMode.jsm → Add error reporters to the Task.spawns within browser/components/customizableui
Comment 2•11 years ago
|
||
Comment on attachment 793617 [details] [diff] [review] Patch Review of attachment 793617 [details] [diff] [review]: ----------------------------------------------------------------- rs=me assuming you used grep or equivalent correctly (ie caught everything) and passing null as the first argument doesn't confuse Task.jsm (id est, you tested this and it works) Thanks!
Attachment #793617 -
Flags: review?(gijskruitbosch+bugs) → review+
Assignee | ||
Comment 3•11 years ago
|
||
Yeah, I tested with a couple of the Task.spawn usages and it worked.
Assignee | ||
Comment 4•11 years ago
|
||
https://hg.mozilla.org/projects/ux/rev/96b43964e8b3
Whiteboard: [Australis:M8][fixed-in-ux]
Assignee | ||
Comment 5•11 years ago
|
||
Whoops, ERROR doesn't exist in panelUI.js or head.js.
Attachment #793636 -
Flags: review?(gijskruitbosch+bugs)
Updated•11 years ago
|
Attachment #793636 -
Flags: review?(gijskruitbosch+bugs) → review+
Comment 6•11 years ago
|
||
Comment on attachment 793636 [details] [diff] [review] Patch pt 2 https://hg.mozilla.org/projects/ux/rev/542ac829409f
Comment 7•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/96b43964e8b3 https://hg.mozilla.org/mozilla-central/rev/542ac829409f
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M8][fixed-in-ux] → [Australis:M8]
Target Milestone: --- → Firefox 28
You need to log in
before you can comment on or make changes to this bug.
Description
•