Closed Bug 907796 Opened 8 years ago Closed 7 years ago

Add error reporters to the Task.spawns within browser/components/customizableui

Categories

(Firefox :: Toolbars and Customization, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
Firefox 28

People

(Reporter: jaws, Assigned: jaws)

References

(Blocks 1 open bug)

Details

(Whiteboard: [Australis:M8])

Attachments

(2 files)

We need to add error handlers inside of the Task.spawns within CustomizeMode.jsm (and possibly elsewhere within the customization code).
Attached patch PatchSplinter Review
Attachment #793617 - Flags: review?(gijskruitbosch+bugs)
Summary: Add error reporters to the Task.spawns within CustomizeMode.jsm → Add error reporters to the Task.spawns within browser/components/customizableui
Comment on attachment 793617 [details] [diff] [review]
Patch

Review of attachment 793617 [details] [diff] [review]:
-----------------------------------------------------------------

rs=me assuming you used grep or equivalent correctly (ie caught everything) and passing null as the first argument doesn't confuse Task.jsm (id est, you tested this and it works)

Thanks!
Attachment #793617 - Flags: review?(gijskruitbosch+bugs) → review+
Yeah, I tested with a couple of the Task.spawn usages and it worked.
Attached patch Patch pt 2Splinter Review
Whoops, ERROR doesn't exist in panelUI.js or head.js.
Attachment #793636 - Flags: review?(gijskruitbosch+bugs)
Attachment #793636 - Flags: review?(gijskruitbosch+bugs) → review+
https://hg.mozilla.org/mozilla-central/rev/96b43964e8b3
https://hg.mozilla.org/mozilla-central/rev/542ac829409f
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Whiteboard: [Australis:M8][fixed-in-ux] → [Australis:M8]
Target Milestone: --- → Firefox 28
You need to log in before you can comment on or make changes to this bug.