Closed
Bug 907853
Opened 11 years ago
Closed 11 years ago
Disable overlay scrollbars in contexts other than the viewport and form controls
Categories
(Core :: Layout, defect)
Tracking
()
RESOLVED
WONTFIX
Tracking | Status | |
---|---|---|
firefox23 | --- | unaffected |
firefox24 | --- | wontfix |
firefox25 | --- | wontfix |
firefox26 | --- | wontfix |
People
(Reporter: spohl, Assigned: spohl)
References
()
Details
(Whiteboard: [lion-scrollbars+])
Attachments
(1 file)
4.80 KB,
patch
|
Details | Diff | Splinter Review |
Bug 891136 required changes both on our side and Google Doc's side. Although we fixed the immediate issue on our side that prevented overlay scrollbars to appear correctly in Google Docs, we'd like to have a fallback in place should Google Docs be unable to push a fix on their end before we ship overlay scrollbars. The idea is to disable overlay scrollbars in contexts other than the viewport and form controls. The link in the URL field can be used to reproduce the issue on Google Docs.
Assignee | ||
Comment 1•11 years ago
|
||
Draft patch by :roc. Only thing changed so far is an added null check (mOuter->GetContent()) in nsGfxScrollFrameInner::UseOverlayScrollbars to prevent crashing. This doesn't quite work yet on Google Docs.
Updated•11 years ago
|
status-firefox23:
--- → unaffected
status-firefox24:
--- → affected
status-firefox25:
--- → affected
status-firefox26:
--- → affected
tracking-firefox24:
--- → +
tracking-firefox25:
--- → +
tracking-firefox26:
--- → +
Assignee | ||
Comment 2•11 years ago
|
||
A quick update on this (and why this might be more involved/risky than first thought): Aside from nsHTMLScrollFrame in nsGfxScrollFrame.cpp, we also need to modify the "UseOverlayScrollbars" checks in our widget theme code, i.e. in nsNativeThemeCocoa.mm. I don't have a great way to do this yet, but maybe we can achieve this by moving roc's nsGfxScrollFrameInner::UseOverlayScrollbars() method to nsIScrollableFrame for example. We could then call it from the theme code to check whether the current context should use overlay or regular scrollbars. This would probably require us to add mIsRoot from nsHTMLScrollFrame to nsIScrollableFrame and track it there. Another problem is that we're using CSS in nativescrollbars.css to hide overlay scrollbars (see [1] and [2]). If we start mixing both types of scrollbars we also need to do something about that. We could, for example, dynamically remove the visibility:hidden rule in the nsGfxScrollFrameInner constructor. Or, we could remove the CSS from nativescrollbars.css completely and always dynamically set it. Overall, I feel like a fix for this bug would be riskier than first thought. Rob, I'd be curious to hear your assessment here. [1] http://dxr.mozilla.org/mozilla-central/source/layout/style/nsCSSRuleProcessor.cpp#l1143 [2] http://dxr.mozilla.org/mozilla-central/source/toolkit/themes/osx/global/nativescrollbars.css?from=nativescrollbars.css#l29
Flags: needinfo?(roc)
Assignee | ||
Comment 3•11 years ago
|
||
Google has pushed a fix on their end that fixes the issue on Google Docs. After speaking with :roc, we've decided to cancel this fallback.
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Flags: needinfo?(roc)
Resolution: --- → WONTFIX
Assignee | ||
Updated•11 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•