hashtables of one (or occasionally two) elements!

VERIFIED FIXED in mozilla0.9.3

Status

()

Core
CSS Parsing and Computation
P1
normal
VERIFIED FIXED
17 years ago
4 years ago

People

(Reporter: dbaron, Assigned: dbaron)

Tracking

({perf})

Trunk
mozilla0.9.3
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

mMediumCascadeTable in nsCSSStyleSheet is a table mapping media atoms to rule
cascades.  We generally have one medium ("screen"), although occasionally we
have a second ("print").  I'll attach a patch to make it a linked list, but I
imagine this will greatly improve the performance of GetRuleCascade for the case
where we already have a rule cascade cached.  (I'll profile shortly...)
Status: NEW → ASSIGNED
Keywords: perf
Priority: -- → P1
Target Milestone: --- → mozilla0.9.3
Yeah, this cut about 40% of the time out of GetRuleCascade (so that it takes a
lot less time all but the first time it's called).

Comment 3

17 years ago
Looks like a good change. I also likes patches that removes more lines than they 
add. :-)

Comment 4

17 years ago
r=waterson

Comment 5

17 years ago
sr=attinasi
Fix checked in 2001-07-16 13:59 PDT.
Status: ASSIGNED → RESOLVED
Last Resolved: 17 years ago
Resolution: --- → FIXED

Comment 7

17 years ago
This caused the regresion at bug 93106

Comment 8

17 years ago
was there any profile on the perf improvements?
Yes, see my 2001-07-14 comments.

Comment 10

16 years ago
verified as per comments
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.