907910 - Allow admins to contact the app owner from the lookup tool

Status: VERIFIED FIXED

(Marketplace Graveyard :: Admin Tools, enhancement, P3)

Description

[krupa raj[:krupa]]

Right now, the Author field is not linkified in the lookup tool. I presume that this is so because we extract that info from the manifest.

However it will be convenient for admins/BD who work with devs to have a way to contact the owner of the app they are looking into. We can add a contact link, may be.

https://marketplace-dev.allizom.org/lookup/app/393011/summary

Comment 1

[Christopher Van Wiemeersch [:cvan]]

https://github.com/mozilla/zamboni/commit/7e235f4

I've added the authors' emails to the Lookup Tool listing:
http://cl.ly/image/2W3v3r203g2r/Screen%20Shot%202013-08-21%20at%202.09.00%20PM.png

Before closing this bug, we should consider linking to the Communication Dashboard from here or adding a contact form as Krupa suggests in comment 0.

Comment 2

[Andrew Williamson [:eviljeff]]

Can we instead change the developer name into a link that links to their account lookup page (which has the email address, among other useful info)?

(showing the email address on the app lookup page is okay too, as added in https://github.com/mozilla/zamboni/commit/7e235f4 )

Comment 3

[Matt Basta [:basta]]

We should probably also add integration with commbadge at some point.

Comment 4

[Mathieu Pillard [:mat]]

Fixed in https://github.com/mozilla/zamboni/commit/a70488fabc12905da462b82ef5df3aaa956938e5

Comment 5

[krupa raj[:krupa]]

STR:

1. Load https://marketplace-dev.allizom.org/lookup/app/393011/summary
2. Click on the author "ducker" 
3. Notice that https://marketplace-dev.allizom.org/lookup/user/4771218/summary loads which is a 500


observed behavior:

traceback!

Also, no matter what app owner you click on, https://marketplace-dev.allizom.org/lookup/user/4771218/summary loads (ducker, twitter Inc, facebook etc) which looks like a link to the admin's user lookup page

traceback details:
Stacktrace (most recent call last):

  File "django/core/handlers/base.py", line 112, in get_response
    response = wrapped_callback(request, *callback_args, **callback_kwargs)
  File "newrelic/hooks/framework_django.py", line 492, in wrapper
    return wrapped(*args, **kwargs)
  File "amo/decorators.py", line 32, in wrapper
    return func(request, *args, **kw)
  File "amo/decorators.py", line 32, in wrapper
    return func(request, *args, **kw)
  File "amo/decorators.py", line 62, in wrapper
    return f(request, *args, **kw)
  File "mkt/lookup/views.py", line 86, in user_summary
    provider_portals = get_payment_provider_portals(user=user)
  File "mkt/lookup/views.py", line 543, in get_payment_provider_portals
    provider = get_provider(id=acct.payment_account.provider)
  File "mkt/developers/providers.py", line 460, in get_provider
    'allowed PAYMENT_PROVIDERS.'.format(p=provider.name))


sentry: http://sentry.dmz.phx1.mozilla.com/marketplace-dev/marketplace-dev/group/20124/

Comment 6

[krupa raj[:krupa]]

On stage, there is no traceback but we still just load the admin user's lookup page instead of the clicked-on app user's lookup page.

Comment 7

[Mathieu Pillard [:mat]]

I don't think the traceback is mine, but the link is definitely wrong, I'll fix that.

Comment 8

[Mathieu Pillard [:mat]]

https://github.com/mozilla/zamboni/commit/952804c263f818a724564333ef0c24b5e668088f will fix the link.

Comment 9

[Mathieu Pillard [:mat]]

The traceback happens when you look at an account referencing a payment provider not enabled in the settings. This is not something new or caused my code, I filed bug 1041552 for it. You can test this bug with other accounts to verify it.

Comment 10

[Kumar McMillan [:kumar]]

this is in the 2014.07.22 release tag https://github.com/mozilla/zamboni/compare/2014.07.08...2014.07.22

Comment 11

[krupa raj[:krupa]]

verified fixed at https://marketplace.allizom.org/lookup/app/393011/summary